The UMAs to better understand what is going on, and the flavors because of e.g. b/119577534
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cd7f8429ff4cad0ec34087f168f1978d2e8b372 commit 7cd7f8429ff4cad0ec34087f168f1978d2e8b372 Author: Yves Arrouye <drcrash@google.com> Date: Tue Nov 20 00:20:00 2018 Separate initial enrollments from forced re-enrollments Bug: chromium:905702 Test: manual, unit tests Change-Id: I8e6902706a67eaa1e712c6c1147c4cc696b67fb2 Reviewed-on: https://chromium-review.googlesource.com/c/1338170 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#609521} [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/chrome/browser/chromeos/login/enrollment/enrollment_screen.cc [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/chrome/browser/chromeos/login/enrollment/enrollment_screen_unittest.cc [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/chrome/browser/chromeos/login/enrollment/enrollment_uma.cc [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/chrome/browser/chromeos/login/wizard_controller_browsertest.cc [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/chrome/browser/chromeos/policy/auto_enrollment_client_impl.cc [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/chrome/browser/chromeos/policy/auto_enrollment_client_impl_unittest.cc [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/chrome/browser/chromeos/policy/device_cloud_policy_initializer_unittest.cc [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/chrome/browser/chromeos/policy/enrollment_config.h [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/chrome/browser/chromeos/policy/server_backed_device_state.cc [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/chrome/browser/chromeos/policy/server_backed_device_state.h [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/chrome/browser/chromeos/system/device_disabling_manager.cc [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/chrome/browser/chromeos/system/device_disabling_manager_unittest.cc [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/chrome/browser/policy/test/policy_testserver.py [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/components/policy/core/common/cloud/enterprise_metrics.h [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/components/policy/proto/device_management_backend.proto [modify] https://crrev.com/7cd7f8429ff4cad0ec34087f168f1978d2e8b372/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05bd1009f026be9dee43979ad748e9e17a2c9ea5 commit 05bd1009f026be9dee43979ad748e9e17a2c9ea5 Author: Daniel Bratell <bratell@opera.com> Date: Tue Nov 20 19:23:33 2018 Resolve conflict between two policy::kMaxValue Both components/policy/core/common/cloud/machine_level_user_cloud_policy_metrics.h and components/policy/core/common/cloud/enterprise_metrics.h define policy::kMaxValue in two different enums. If code includes both headers, it won't compile and this happens in some jumbo build configurations. This patch changes one of the enums to use enum class so that the symbols are in different namespaces. (One will shadow the other but as long as they are used correctly it will be fine) Bug: 905702 Change-Id: Ia4dd0c89dc8ec5c23c516e90eae7f6c3256a232a Reviewed-on: https://chromium-review.googlesource.com/c/1344129 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#609769} [modify] https://crrev.com/05bd1009f026be9dee43979ad748e9e17a2c9ea5/components/policy/core/common/cloud/machine_level_user_cloud_policy_metrics.h
Enterprise.EnrollmentForcedInitial, Enterprise.EnrollmentForcedInitialAttestationBased, Enterprise.EnrollmentForcedInitialManualFallback
Comment 1 by afakhry@google.com
, Nov 16Components: Enterprise>Enrollment
Owner: ----
Status: Untriaged (was: Assigned)