New issue
Advanced search Search tips

Issue 905692 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 780972
Owner:
Closed: Nov 19
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove security_bits from net::SSLInfo

Project Member Reported by dmcardle@chromium.org, Nov 15

Issue description

davidben suggests removing the `security_bits` field from `net::SSLInfo`.

The field is serialized in the HTTP cache, so we still want to be able to parse old entries.
 
Cc: -dmcardle@chromium.org davidben@chromium.org
Owner: dmcardle@chromium.org
Status: Assigned (was: Untriaged)
This may be a dupe of 780972.
Mergedinto: 780972
Status: Duplicate (was: Assigned)
So it is!
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289

commit 2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289
Author: Daniel McArdle <dmcardle@chromium.org>
Date: Wed Nov 28 20:58:08 2018

Remove security_bits field from SSL-related structs

Page info no longer displays the number of bits of security, so we no longer
need the various security_bits fields contained in SSL structs.

Specifically, this patch removes security_bits from the following
structs/classes:
  * net::SSLInfo
  * content::SSLStatus,
  * security_state::VisibleSecurityState
  * security_state::SecurityInfo

Bug:  905692 
Change-Id: Ia55be6573476453c8dfcabc7dcf36b9ddf27d290
Reviewed-on: https://chromium-review.googlesource.com/c/1338259
Commit-Queue: Daniel McArdle <dmcardle@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611862}
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/chrome/browser/ssl/security_state_tab_helper_browsertest.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/chrome/browser/ssl/ssl_browsertest.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/chrome/browser/ui/page_info/page_info.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/chrome/browser/ui/page_info/page_info_unittest.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/components/security_state/content/content_utils.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/components/security_state/core/security_state.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/components/security_state/core/security_state.h
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/components/security_state/core/security_state_unittest.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/content/browser/frame_host/navigation_entry_impl_unittest.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/content/browser/loader/resource_loader_unittest.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/content/common/common_param_traits_unittest.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/content/public/browser/ssl_status.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/content/public/browser/ssl_status.h
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/ios/web/net/request_tracker_impl_unittest.mm
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/net/http/http_response_info.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/net/quic/quic_chromium_client_session.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/net/socket/ssl_client_socket_impl.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/net/socket/ssl_server_socket_impl.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/net/ssl/ssl_info.h
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/2bd4fd8e90cf59edf3b6883ca8cbb55d7e0e8289/services/network/public/cpp/net_ipc_param_traits.cc

Sign in to add a comment