Migrate the IdentityTestEnvironment{Profile, ChromeBrowserState}Adaptor clients that pass PrefService to do so via the Builder variant |
||
Issue descriptionEliminate the |prefs| optional arg and keep just the variants that take in only TestingFactories and that take in a Builder.
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b0eebbf70c7102ffd16ffc3078f3aa883df8c0c commit 3b0eebbf70c7102ffd16ffc3078f3aa883df8c0c Author: Antonio Gomes <tonikitoo@igalia.com> Date: Tue Nov 20 12:09:45 2018 [s13n] Migrate the IdentityTestEnvironmentProfileAdaptor clients that pass PrefService to use Builder variant The "build variant" is more powerful, than the one that takes a |prefs| as parameter. TBR=emaxx@chromium.org (chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc) BUG= 905687 Change-Id: I622446888ad8e31ef3fd0d464ac5ab25375abf3c Reviewed-on: https://chromium-review.googlesource.com/c/1340889 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#609669} [modify] https://crrev.com/3b0eebbf70c7102ffd16ffc3078f3aa883df8c0c/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc [modify] https://crrev.com/3b0eebbf70c7102ffd16ffc3078f3aa883df8c0c/chrome/browser/signin/identity_test_environment_profile_adaptor.cc [modify] https://crrev.com/3b0eebbf70c7102ffd16ffc3078f3aa883df8c0c/chrome/browser/signin/identity_test_environment_profile_adaptor.h
,
Nov 20
|
||
►
Sign in to add a comment |
||
Comment 1 by toniki...@chromium.org
, Nov 15Status: Started (was: Available)