New issue
Advanced search Search tips

Issue 905680 link

Starred by 1 user
Status: Available
Owner:
jlebel@chromium.org
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Migrate UDC settings to the new API (Web and interactions).

Project Member Reported by jlebel@chromium.org, Nov 15 
UDC settings should use the new API:
Example of the changes that has to be done:
https://critique.corp.google.com/#review/221609691

This changes are located:
https://cs.corp.google.com/chrome-ios_internal/chrome/browser/providers/signin/chrome_identity_service_impl.mm?l=212

BUILD.gn files have to be updated to include the new classes.

Comment 1 by jlebel@chromium.org, Nov 15 

The previous code will be removed by https://b.corp.google.com/issues/113854437 (once this bug is closed).

Comment 2 by jlebel@chromium.org, Nov 26 

Document to explain pros and cons for the new UDC:
https://docs.google.com/document/d/1VjZ3Gw6AEI4aTKB5bPer_1riB2GsluvqN-DVXe7k4xg

Answer from Mardini:
"OK. Just to confirm our offline discussion for Pink's sake: I am ok with using SFViewController for this use case given the benefits/gains/impact from using Chrome do not ouweigh the maintainability and engineering pain. "
►

Sign in to add a comment