Manual Fallback: Address physical keyboard on iPhones |
||||||
Issue descriptionFix the accessory view on iPhones with a physical keyboard
,
Nov 19
On iPhones with safe areas, the input accessory view is broken when a physical keyboard is connected.
,
Nov 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3aa33b807862ad6ea18155d112c4d7861b42a016 commit 3aa33b807862ad6ea18155d112c4d7861b42a016 Author: David Jean <djean@google.com> Date: Fri Nov 23 10:29:34 2018 [ios] Fixed manual fallback when using hardware keyboard Bug: 905657 Change-Id: I4c535ba13c2a8e97fbaf217aebafd222b791cd3c Reviewed-on: https://chromium-review.googlesource.com/c/1344055 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#610561} [modify] https://crrev.com/3aa33b807862ad6ea18155d112c4d7861b42a016/ios/chrome/browser/autofill/form_input_accessory_consumer.h [modify] https://crrev.com/3aa33b807862ad6ea18155d112c4d7861b42a016/ios/chrome/browser/autofill/form_input_accessory_view.mm [modify] https://crrev.com/3aa33b807862ad6ea18155d112c4d7861b42a016/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm [modify] https://crrev.com/3aa33b807862ad6ea18155d112c4d7861b42a016/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm [modify] https://crrev.com/3aa33b807862ad6ea18155d112c4d7861b42a016/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.mm
,
Nov 23
,
Nov 23
,
Nov 27
Need info to verify. Is this the correct UI for this fix? I do not see the "Done" button anymore but instead a "X" to close -is this WAI? Version: Chrome Canary 72.0.3623.0 Device: iPhone 8 iOS: 12.0 https://drive.google.com/open?id=1W3Tgy_mEyAK1dtc1WOFGQUqCFiLmoX4v
,
Nov 27
,
Nov 28
The Done button appearing is the Apple's default keyboard accessory. This is a bug, but probably a different one. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kkhorimoto@chromium.org
, Nov 15