New issue
Advanced search Search tips

Issue 905652 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task

Blocking:
issue 845472



Sign in to add a comment

Manual Fallback: Show alert on unsafe & unsupported password fields

Project Member Reported by javierrobles@chromium.org, Nov 15

Issue description

Tell the user why a password is not being filled in non HTTPS forms and in non-password fields.
 
Components: UI>Browser>Autofill
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d670fd60743918a34bc7b906dde3cfbbc0944ca0

commit d670fd60743918a34bc7b906dde3cfbbc0944ca0
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Wed Nov 21 10:09:17 2018

[iOS][MF] Show an alert when a field won't be filled

Only fill credit cards on HTTPS, and passwords on HTTPS and password
fields. Show an alert to the user otherwise.

Bug:  905652 , 878388,  845472 
Change-Id: I51e0f07757dc4f7f1e002b88b83a2d2eeea071b5
Reviewed-on: https://chromium-review.googlesource.com/c/1340259
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609980}
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/BUILD.gn
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/manual_fill/card_mediator.mm
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.mm
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_card_cell.mm
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_content_delegate.h
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_injection_handler.h
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_injection_handler.mm
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_password_cell.mm
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/manual_fill/password_mediator.mm

Status: Fixed (was: Assigned)
Blocking: 845472

Sign in to add a comment