Animate the suggestions disappearing
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c5020fdfc05622997bd51495d804c41a884a07a commit 5c5020fdfc05622997bd51495d804c41a884a07a Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Mon Nov 19 17:35:49 2018 [iOS][MF] Disable accessory view animation Disabling the manual fill accessory animation until the suggestion animation is done. Animating the suggestions disappearing is hard and it looks better with no animations than with one animation in one part and no animation in the other. Bug: 845472 , 905660 , 905651 Change-Id: Ic0d9de58a85b0e5366105102f0bf3706e5ce42ba Reviewed-on: https://chromium-review.googlesource.com/c/1341995 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#609348} [modify] https://crrev.com/5c5020fdfc05622997bd51495d804c41a884a07a/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbd360b334ef36a9d178738814f2ec52e4c9e52a commit dbd360b334ef36a9d178738814f2ec52e4c9e52a Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Fri Nov 23 15:23:17 2018 [iOS][MF] Animate suggestions out and in In order to add the animations some refactoring was required. This also updates the suggestions view and form accessory view instead of recreating them every time new suggestions arrive. Continues the UI layering of these views, by removing the navigator related logic from them. Relies on setting content insets instead of removing suggestions to lock on the manual fill icons. Refactors names of delegates and properties to more appropriate ones Fixes an issue when disabled suggestions was ignored when jumping between fields. Bug: 905651 , 907084, 845472 , 905660 Change-Id: I4ceebcabadbb26e6d948c26f9691d5684a143b79 Reviewed-on: https://chromium-review.googlesource.com/c/1346833 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610611} [modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/BUILD.gn [modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_accessory_consumer.h [modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_accessory_view.h [modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_accessory_view.mm [modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_accessory_view_controller.h [modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm [modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_accessory_view_handler.h [modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_accessory_view_handler.mm [rename] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_navigator.h [modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_suggestions_provider.h [modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_suggestion_controller.mm [modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm [modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_suggestion_view.h [modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_suggestion_view.mm [modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm [modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.h [modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.mm [modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm
Comment 1 by kkhorimoto@chromium.org
, Nov 15