New issue
Advanced search Search tips

Issue 905650 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task

Blocking:
issue 845472



Sign in to add a comment

Manual Fallback: Hide profiles and credit cards when empty

Project Member Reported by javierrobles@chromium.org, Nov 15

Issue description

Don't show the icons in the accessory bar if the user doesn't have data available.
 
Components: UI>Browser>Autofill
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff7402f2bd091fa13c558454077d3448d4f07747

commit ff7402f2bd091fa13c558454077d3448d4f07747
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Thu Nov 15 19:04:47 2018

[iOS][MF] Hide and show autofill buttons

Hide card and address icons when no data is available. Show them again
if data becomes available.

Bug:  845472 ,  905650 
Change-Id: If0420746b2df8fd3ebbbbd8dff6524eb326cef7c
Reviewed-on: https://chromium-review.googlesource.com/c/1335570
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608462}
[modify] https://crrev.com/ff7402f2bd091fa13c558454077d3448d4f07747/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
[modify] https://crrev.com/ff7402f2bd091fa13c558454077d3448d4f07747/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.h
[modify] https://crrev.com/ff7402f2bd091fa13c558454077d3448d4f07747/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm

Status: Fixed (was: Assigned)
Blocking: 845472

Sign in to add a comment