New issue
Advanced search Search tips

Issue 905646 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Nov 22
Cc:
dvadym@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

No manual fallback for saving on the sign-up form on elitepvpers.com

Project Member Reported by kolos@chromium.org, Nov 15 
Chrome Version: (copy from chrome://version)
OS: Linux (and probably other desktop platforms)

What steps will reproduce the problem?
(0) New parser for saving should be enabled
(1) Go to https://www.elitepvpers.com/forum/register.php
(2) Accept terms and conditions, fill account data and press "Complete Registration"
(3) 

What is the expected result?
Save prompt should appear (or manual fallback for saving at least)

What happens instead?
Neither automatic nor manual fallback are available

Comment 1 by kolos@chromium.org, Nov 15 

Brief investigation: after navigation, the |NewPasswordFormManager::IsNewLogin| returns false and therefore |ShouldPromptUserToSavePassword| returns false => no prompt/no fallback.

Comment 2 by vabr@chromium.org, Nov 16

Labels: Needs-Feedback
Status: Untriaged (was: Available)
Hmm, I just tried on ToT (72.0.3613.0) Linux, with --enable-features=new-password-form-parsing,new-password-form-parsing-for-saving and manual fallback for saving seems to work.

Could you please confirm your Chrome version, Maxim?

Comment 3 by vabr@chromium.org, Nov 16 

To be precise, manual fallback for saving works for me both on the sign-up and the sign-in form. Once saved, the credentials are also autofilled in the sign-in form.

Comment 4 by kolos@chromium.org, Nov 22

Status: Fixed (was: Untriaged)
Hi Vaclav! Thanks for checking. I think I had a build with my changes. It is why it didn't work.

Comment 5 by vabr@chromium.org, Nov 29

Cc: -vabr@chromium.org
►

Sign in to add a comment