Remove all consents logic from https://cs.chromium.org/chromium/src/components/sync/user_events/?q=TODO+file:%5Esrc/components/sync/user_events/+package:%5Echromium$&dr=C This may allow deprecating consent related fields in UserEvent proto.
also in https://cs.chromium.org/chromium/src/components/consent_auditor/consent_auditor.h?type=cs&q=TODO+file:%5Esrc/components/consent_auditor/+package:%5Echromium$&g=0&l=45 and its implementation.
The proto in question is https://cs.chromium.org/chromium/src/components/sync/protocol/user_event_specifics.proto?g=0. It is better to double check with markusheintz@ before touching the proto.
Also the factories (they should not depend on UserEvents anymore): https://cs.chromium.org/chromium/src/chrome/browser/consent_auditor/consent_auditor_factory.cc?sq=package:chromium&dr=CSs&g=0 https://cs.chromium.org/chromium/src/ios/chrome/browser/sync/consent_auditor_factory.h?q=consent_auditor+f:ios&dr=CSs
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a149413f0faac240b030d995a7832023d63714f9 commit a149413f0faac240b030d995a7832023d63714f9 Author: Marc Treib <treib@chromium.org> Date: Thu Nov 22 16:34:08 2018 Remove launched SyncUserConsentSeparateType feature plus a lot of now-dead code :) Many tests explicitly disabled the feature. Some of those could be adapted, some other simply don't apply anymore and were deleted. Bug: 905636 , 905639 Change-Id: Ife7cf5227b929bab5221b856d85ba572f89e537e Reviewed-on: https://chromium-review.googlesource.com/c/1346308 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#610438} [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/chrome/browser/about_flags.cc [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/chrome/browser/consent_auditor/consent_auditor_factory.cc [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/chrome/browser/flag_descriptions.h [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/chrome/browser/sync/profile_sync_service_factory_unittest.cc [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/chrome/browser/sync/test/integration/single_client_user_consents_sync_test.cc [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/chrome/browser/sync/test/integration/single_client_user_events_sync_test.cc [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/browser_sync/profile_sync_components_factory_impl.cc [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/consent_auditor/consent_auditor.h [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/consent_auditor/consent_auditor_impl.cc [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/consent_auditor/consent_auditor_impl.h [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/consent_auditor/consent_auditor_impl_unittest.cc [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/sync/driver/sync_driver_switches.cc [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/sync/driver/sync_driver_switches.h [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/sync/user_events/user_event_service_impl.cc [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/sync/user_events/user_event_service_impl_unittest.cc [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/unified_consent/feature.cc [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/unified_consent/feature_unittest.cc [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/unified_consent/scoped_unified_consent.cc [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/unified_consent/scoped_unified_consent.h [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/ios/chrome/browser/sync/consent_auditor_factory.cc [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/ios/chrome/browser/sync/profile_sync_service_factory_unittest.cc [modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/ios/web_view/internal/web_view_web_main_parts.mm
Turns out there is more consents code in UserEventSyncBridge.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2ea92842c4d1818ef685d30d731ab488880cc2c commit d2ea92842c4d1818ef685d30d731ab488880cc2c Author: Marc Treib <treib@chromium.org> Date: Fri Nov 23 17:43:26 2018 Cleanup: Remove consent handling code from UserEventSyncBridge Consents have been moved to their own data type and thus have their own Sync bridge. Bug: 905639 Change-Id: Idf4a9ee11b74eac38f158a0135a4a1998f04fe2a Reviewed-on: https://chromium-review.googlesource.com/c/1349649 Reviewed-by: vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#610644} [modify] https://crrev.com/d2ea92842c4d1818ef685d30d731ab488880cc2c/components/sync/user_events/user_event_sync_bridge.cc [modify] https://crrev.com/d2ea92842c4d1818ef685d30d731ab488880cc2c/components/sync/user_events/user_event_sync_bridge.h [modify] https://crrev.com/d2ea92842c4d1818ef685d30d731ab488880cc2c/components/sync/user_events/user_event_sync_bridge_unittest.cc
Now it should be done!
Comment 1 by vitaliii@chromium.org
, Nov 15