New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 905636 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 892076



Sign in to add a comment

Delete SyncUserConsentSeparateType

Project Member Reported by vitaliii@chromium.org, Nov 15

Issue description

Delete SyncUserConsentSeparateType, since it has launched and we don't plan to disable it.
 
Status: Available (was: Untriaged)
Labels: OS-Android OS-Chrome OS-iOS OS-Linux OS-Mac OS-Windows
Owner: treib@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a149413f0faac240b030d995a7832023d63714f9

commit a149413f0faac240b030d995a7832023d63714f9
Author: Marc Treib <treib@chromium.org>
Date: Thu Nov 22 16:34:08 2018

Remove launched SyncUserConsentSeparateType feature

plus a lot of now-dead code :)
Many tests explicitly disabled the feature. Some of those could be
adapted, some other simply don't apply anymore and were deleted.

Bug:  905636 ,  905639 
Change-Id: Ife7cf5227b929bab5221b856d85ba572f89e537e
Reviewed-on: https://chromium-review.googlesource.com/c/1346308
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610438}
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/chrome/browser/about_flags.cc
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/chrome/browser/consent_auditor/consent_auditor_factory.cc
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/chrome/browser/sync/test/integration/single_client_user_consents_sync_test.cc
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/chrome/browser/sync/test/integration/single_client_user_events_sync_test.cc
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/browser_sync/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/consent_auditor/consent_auditor.h
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/consent_auditor/consent_auditor_impl.cc
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/consent_auditor/consent_auditor_impl.h
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/consent_auditor/consent_auditor_impl_unittest.cc
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/sync/driver/sync_driver_switches.cc
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/sync/driver/sync_driver_switches.h
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/sync/user_events/user_event_service_impl.cc
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/sync/user_events/user_event_service_impl_unittest.cc
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/unified_consent/feature.cc
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/unified_consent/feature_unittest.cc
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/unified_consent/scoped_unified_consent.cc
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/components/unified_consent/scoped_unified_consent.h
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/ios/chrome/browser/sync/consent_auditor_factory.cc
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/ios/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/a149413f0faac240b030d995a7832023d63714f9/ios/web_view/internal/web_view_web_main_parts.mm

Status: Fixed (was: Started)
Labels: sync-fixit-2018q4

Sign in to add a comment