New issue
Advanced search Search tips

Issue 905630 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Nov 15
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Darker background of the location bar isn't pill shaped

Project Member Reported by gambard@chromium.org, Nov 15 
Chrome Version: 72.0.3611.0

What steps will reproduce the problem?
(1) Open a Web page
(2) Long press the omnibox

What is the expected result?
The darker shadow above the omnibox during the long press should have the same shape as the omnibox (a pill).

What happens instead?
The darker shadow is rectangular.
Simulator Screen Shot - iPhone XS - 2018-11-15 at 14.06.28.png
475 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33d9de49a9a8bf7105b7dc2bffb70c701355e6c1

commit 33d9de49a9a8bf7105b7dc2bffb70c701355e6c1
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Nov 15 14:39:55 2018

[iOS] Fix SteadyView highlighted state shape

This CL changes the state of the highlighted state of the location bar,
to have it shaped like a pill, as the non-highlighted state.

Bug:  905630 
Change-Id: Ieeb5180d514b928c158ed2cd4f5b39cfde2b7aec
Reviewed-on: https://chromium-review.googlesource.com/c/1337500
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608363}
[modify] https://crrev.com/33d9de49a9a8bf7105b7dc2bffb70c701355e6c1/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm

Comment 2 by gambard@chromium.org, Nov 15

Status: Fixed (was: Assigned)

Comment 3 by vbarig...@chromium.org, Nov 21

Status: Verified (was: Fixed)
Verified on chrome canary version 72.0.3617.0 on iPhone 7 plus with iOS 12.1 and iPhone X with iOS 11.4.1.  Dark background color on long press is in oval shape.  Looks good.
►

Sign in to add a comment