[WPT] New failures introduced in external/wpt/css/css-text by import https://crrev.com/c/1337629 |
|||
Issue descriptionWPT import https://crrev.com/c/1337629 introduced new failures in external/wpt/css/css-text: List of new failures: external/wpt/css/css-text/writing-system/writing-system-segment-break-001.html [ Failure ] external/wpt/css/css-text/writing-system/writing-system-line-break-001.html [ Failure ] external/wpt/css/css-text/writing-system/writing-system-line-break-002.html [ Failure ] external/wpt/css/css-text/writing-system/writing-system-text-transform-001.html [ Failure ] This import contains upstream changes from 42abd6cc7ebd7c0b0513639e1a8c1bd958638fed to 0ddb31913184805fa3725e22e5b88046e961996b: [testharness.js] Honor test config in workers (#14061): https://github.com/web-platform-tests/wpt/commit/0ddb31913184805fa3725e22e5b88046e961996b Merge pull request #13430 from frivoal/writing-system: https://github.com/web-platform-tests/wpt/commit/9b65752bd8f279c76532401268f06250ac5d479c fix typo: https://github.com/web-platform-tests/wpt/commit/643c8394abb53fbca39590728bc30ad96b1feb6c [affecting this directory] [css-text][css-fonts] Testing writing system dependent rules: https://github.com/web-platform-tests/wpt/commit/60e792e88bf7e2839b584354b128600bb89a7e8f [affecting this directory]
,
Nov 15
,
Nov 16
"you did something interesting" is a nice way of putting it :) The failures reported in this bug are all for new tests in https://github.com/web-platform-tests/wpt/pull/13430, and my commit was on that PR branch. I've sent https://github.com/web-platform-tests/wpt/pull/14097 to fix it.
,
Nov 16
Oh, I see. I tend to forget that github uses git the way it's meant to be used, with proper merges, so I thought the other commit was landed months ago. :) Thanks. Thank you for #14097. The rest is failures that our team needs to figure out then. In LayoutNG, external/wpt/css/css-text/writing-system/writing-system-segment-break-001.html passes. I'll file a CL to update the expectations file.
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/337f2155e3fc3d7240ca7d6258835ef3fc01a70e commit 337f2155e3fc3d7240ca7d6258835ef3fc01a70e Author: Morten Stenshorne <mstensho@chromium.org> Date: Fri Nov 16 14:16:46 2018 [LayoutNG] One css-text/writing-system/ test passes. writing-system-segment-break-001.html fails in legacy layout, but not in LayoutNG. Also moved two failure expectation lines to the right place. They clearly don't belong in the "New passes" category. TBR=kojii@chromium.org Bug: 905629 Change-Id: Ie3d036d53defbbbbb78d86313c56fe885b602d69 Reviewed-on: https://chromium-review.googlesource.com/c/1340302 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#608762} [modify] https://crrev.com/337f2155e3fc3d7240ca7d6258835ef3fc01a70e/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG |
|||
►
Sign in to add a comment |
|||
Comment 1 by mstensho@chromium.org
, Nov 15Status: Assigned (was: Untriaged)