New issue
Advanced search Search tips

Issue 905612 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Improve Clear Browsing Data test coverage on Android

Project Member Reported by dullweber@chromium.org, Nov 15

Issue description

We don't properly test the deletion of many types of browsing data on Android.
We should implement a similar approach to BrowsingDataRemoverBrowserTestP, where data is created and a deletion is observed using Javascript.
 
TODO: also test SingleWebsitePreference and SessionStorage
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6c4b8d7c419f17dbaaaf534a5c305f7041b6d9d

commit c6c4b8d7c419f17dbaaaf534a5c305f7041b6d9d
Author: Christian Dullweber <dullweber@chromium.org>
Date: Mon Nov 19 10:35:17 2018

Add browsing data deletion tests for Android

Add tests similar to BrowsingDataRemoverBrowserTest to Android.
They verify that cookies and other data is counted and deleted
correctly by Clear Browsing Data.
To perform asynchronous calls to Javascript, this adds support for
DomAutomationController.send on Android.

Bug: 905612,  562487 
Change-Id: I2c5d3929cf4e1eed704b21b55ad9988b5a09c53e
Reviewed-on: https://chromium-review.googlesource.com/c/1339864
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609229}
[modify] https://crrev.com/c6c4b8d7c419f17dbaaaf534a5c305f7041b6d9d/chrome/android/BUILD.gn
[modify] https://crrev.com/c6c4b8d7c419f17dbaaaf534a5c305f7041b6d9d/chrome/android/java_sources.gni
[add] https://crrev.com/c6c4b8d7c419f17dbaaaf534a5c305f7041b6d9d/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/BrowsingDataTest.java
[modify] https://crrev.com/c6c4b8d7c419f17dbaaaf534a5c305f7041b6d9d/content/public/test/android/BUILD.gn
[add] https://crrev.com/c6c4b8d7c419f17dbaaaf534a5c305f7041b6d9d/content/public/test/android/javatests/src/org/chromium/content_public/browser/test/util/DomAutomationController.java
[modify] https://crrev.com/c6c4b8d7c419f17dbaaaf534a5c305f7041b6d9d/content/public/test/android/javatests/src/org/chromium/content_public/browser/test/util/JavaScriptUtils.java

Sign in to add a comment