New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 905606 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: TwoClientWalletSyncTest.ServerAddressConvertsToSameLocalAddress



Sign in to add a comment

*/TwoClientWalletSyncTest.ServerAddressConvertsToSameLocalAddress/* is flaky

Project Member Reported by Findit, Nov 15

Issue description


Flaky test: USS/TwoClientWalletSyncTest.ServerAddressConvertsToSameLocalAddress/1
Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/4906
Test output log: https://chromium-swarm.appspot.com/task?id=412fbd0dab021710
Culprit (100.0% confidence): r608003
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy3wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKoAWNocm9taXVtLmxpbnV4L2xpbnV4LXhlbmlhbC1yZWwvNDkwNi9zeW5jX2ludGVncmF0aW9uX3Rlc3RzIG9uIFVidW50dS0xNi4wNC9WVk5UTDFSM2IwTnNhV1Z1ZEZkaGJHeGxkRk41Ym1OVVpYTjBMbE5sY25abGNrRmtaSEpsYzNORGIyNTJaWEowYzFSdlUyRnRaVXh2WTJGc1FXUmtjbVZ6Y3k4eAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20USS/TwoClientWalletSyncTest.ServerAddressConvertsToSameLocalAddress/1&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy3wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKoAWNocm9taXVtLmxpbnV4L2xpbnV4LXhlbmlhbC1yZWwvNDkwNi9zeW5jX2ludGVncmF0aW9uX3Rlc3RzIG9uIFVidW50dS0xNi4wNC9WVk5UTDFSM2IwTnNhV1Z1ZEZkaGJHeGxkRk41Ym1OVVpYTjBMbE5sY25abGNrRmtaSEpsYzNORGIyNTJaWEowYzFSdlUyRnRaVXh2WTJGc1FXUmtjbVZ6Y3k4eAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8

commit ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Nov 15 10:56:54 2018

Revert "[AF] Integration tests for changing additional info for wallet metadata"

This reverts commit ad793ba03b073e47e865aa2625c9bd12118d6e77.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 608003 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYWQ3OTNiYTAzYjA3M2U0N2U4NjVhYTI2MjVjOWJkMTIxMThkNmU3Nww

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/4906

Sample Failed Step: sync_integration_tests on Ubuntu-16.04

Sample Flaky Test: USS/TwoClientWalletSyncTest.ServerAddressConvertsToSameLocalAddress/1

Original change's description:
> [AF] Integration tests for changing additional info for wallet metadata
> 
> This CL adds more integration tests; it also fixes a bug that
> stopped local changes of billing address and local changes of
> has_converted to get propagated to sync.
> 
> Bug:  894001 
> Change-Id: Idd91e6799afd3c936b76ac8b1a6851abc67b5ad7
> Reviewed-on: https://chromium-review.googlesource.com/c/1333819
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Commit-Queue: Jan Krcal <jkrcal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608003}

Change-Id: I6a879efbc643e4aa282ebe8d94c9e43566ab9eba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  894001 ,  905606 
Reviewed-on: https://chromium-review.googlesource.com/c/1337631
Cr-Commit-Position: refs/heads/master@{#608311}
[modify] https://crrev.com/ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
[modify] https://crrev.com/ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8/chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
[modify] https://crrev.com/ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8/chrome/browser/sync/test/integration/wallet_helper.cc
[modify] https://crrev.com/ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8/chrome/browser/sync/test/integration/wallet_helper.h
[modify] https://crrev.com/ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
[modify] https://crrev.com/ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.h
[modify] https://crrev.com/ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service_unittest.cc

Labels: -Sheriff-Chromium
Components: Services>Sync
Owner: jkrcal@chromium.org
Status: Assigned (was: Untriaged)
Will take a look.
Status: Fixed (was: Assigned)
Fixed CL has relanded with no new flakes, thus closing this bug.

Sign in to add a comment