Issue metadata
Sign in to add a comment
|
Regression: Focus highlight gets disabled from Previous/Next button after resizing browser window.
Reported by
db...@etouch.net,
Nov 15
|
||||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3610.2 Revision d1388eea987cd8f0f0e28b3570cded07eebae848-refs/branch-heads/3610@{#8}(32/64 bit) OS: Windows(7,8,8.1,10),Linux(14.04 LTS) What steps will reproduce the problem? (1) Launch chrome, open NTP and press Ctrl+F to open 'Find in page' box. (2) Press Tab key upto focus reaches to Previous/Next button then resize browser window and observe focus. Actual: Focus highlight gets disabled from Previous/Next button after resizing browser window. Expected: Focus highligh should stays on Previous/Next button even after resizing browser window. This is a regression issue, broken in 'M72', will soon update the other info: Good Build:72.0.3599.0(Revision: 604792) Bad Build: 72.0.3601.0 (Revision: 605195) Note: Issue is not seen on Mac(10.13.1,10.13.6,14.0.1) OS.
,
Nov 17
,
Nov 22
,
Dec 6
,
Dec 6
,
Dec 11
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a41ce9be4f98f466881ae2a21ff2a8066677c62d commit a41ce9be4f98f466881ae2a21ff2a8066677c62d Author: Tom Anderson <thomasanderson@chromium.org> Date: Thu Dec 13 02:33:48 2018 Apply correct ink drop ripple and highlight state after view resize Only the active state was handled previously for the ink drop ripple, and the visible state wasn't set at all on the highlight. This CL handles all ink drop ripple cases and the highlight visible state. BUG= 905586 , 911770 R=mohsen Change-Id: I0fb383f32dd0c730cd3b38981c87b7447f1878c0 Reviewed-on: https://chromium-review.googlesource.com/c/1366492 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#616172} [modify] https://crrev.com/a41ce9be4f98f466881ae2a21ff2a8066677c62d/ui/views/animation/ink_drop_impl.cc [modify] https://crrev.com/a41ce9be4f98f466881ae2a21ff2a8066677c62d/ui/views/animation/ink_drop_ripple.cc [modify] https://crrev.com/a41ce9be4f98f466881ae2a21ff2a8066677c62d/ui/views/animation/ink_drop_ripple.h
,
Dec 13
,
Dec 14
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 14
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/307322fcaaaec26caf0f60601393ea770788440f commit 307322fcaaaec26caf0f60601393ea770788440f Author: Tom Anderson <thomasanderson@chromium.org> Date: Fri Dec 14 23:39:11 2018 [Merge to M72] Apply correct ink drop ripple and highlight state after view resize > Only the active state was handled previously for the ink drop ripple, > and the visible state wasn't set at all on the highlight. This CL > handles all ink drop ripple cases and the highlight visible state. > > BUG= 905586 , 911770 > R=mohsen > > Change-Id: I0fb383f32dd0c730cd3b38981c87b7447f1878c0 > Reviewed-on: https://chromium-review.googlesource.com/c/1366492 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Mohsen Izadi <mohsen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#616172} BUG= 905586 , 911770 TBR=mohsen NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I9f7a3d5ed5d237e971a879d6088293397075cb97 Reviewed-on: https://chromium-review.googlesource.com/c/1379216 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#376} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/307322fcaaaec26caf0f60601393ea770788440f/ui/views/animation/ink_drop_impl.cc [modify] https://crrev.com/307322fcaaaec26caf0f60601393ea770788440f/ui/views/animation/ink_drop_ripple.cc [modify] https://crrev.com/307322fcaaaec26caf0f60601393ea770788440f/ui/views/animation/ink_drop_ripple.h
,
Dec 14
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/307322fcaaaec26caf0f60601393ea770788440f Commit: 307322fcaaaec26caf0f60601393ea770788440f Author: thomasanderson@chromium.org Commiter: thomasanderson@chromium.org Date: 2018-12-14 23:39:11 +0000 UTC [Merge to M72] Apply correct ink drop ripple and highlight state after view resize > Only the active state was handled previously for the ink drop ripple, > and the visible state wasn't set at all on the highlight. This CL > handles all ink drop ripple cases and the highlight visible state. > > BUG= 905586 , 911770 > R=mohsen > > Change-Id: I0fb383f32dd0c730cd3b38981c87b7447f1878c0 > Reviewed-on: https://chromium-review.googlesource.com/c/1366492 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Mohsen Izadi <mohsen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#616172} BUG= 905586 , 911770 TBR=mohsen NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I9f7a3d5ed5d237e971a879d6088293397075cb97 Reviewed-on: https://chromium-review.googlesource.com/c/1379216 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#376} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by db...@etouch.net
, Nov 15Owner: thomasanderson@chromium.org
Status: Assigned (was: Unconfirmed)