New issue
Advanced search Search tips

Issue 905575 link

Starred by 1 user
Status: Unconfirmed
Owner: ----
Cc:
vamshi.kommuri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Setting thread priorities are broken on Linux when cgroups are not active

Reported by dgunnars...@vewd.com, Nov 15 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36

Steps to reproduce the problem:
1. Run unit-tests on a linux machine without cgroups

What is the expected behavior?
Unit tests should not fail
Priorities should be working even if cgroups are not active on linux systems (like embedded devices).

What went wrong?
This is already fixed and reviewed twice. I don't have more time to spend on upstreaming it. The fix is already running stable here at Vewd for a month.
A patch with solution, extra unit tests are added.

https://chromium.googlesource.com/chromium/src/+/a1ecd9eb4623f43ce6545cd1e28065708857c3f9%5E%21/#F0

https://chromium-review.googlesource.com/c/chromium/src/+/1293457

Did this work before? N/A 

Chrome version: 70.0.3538.77  Channel: n/a
OS Version: 
Flash Version: 

This should be a slam dunk just apply patch and commit.
Good luck!
patch_for_setpriorities_linux.patch
6.4 KB Download

Comment 1 by dtapu...@chromium.org, Nov 15 

 Issue 905576  has been merged into this issue.

Comment 2 by vamshi.kommuri@chromium.org, Nov 16

Cc: vamshi.kommuri@chromium.org
Components: Internals
Labels: Triaged-ET TE-NeedsTriageHelp
Thanks for filing the issue!

As the issue seems to be related to running unit-tests when cgroups are not active, which is out of scope for us to do it from our end. Hence adding label "TE-NeedsTriageHelp" and requesting someone from respective team to have a look into this for further inputs.
Note: Tentatively adding component "Internals", please change if this isn't apt.
►

Sign in to add a comment