New issue
Advanced search Search tips

Issue 905531 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 28
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebglConformance_conformance2_textures_misc_copy_texture_image failing

Project Member Reported by enga@chromium.org, Nov 15

Issue description

Valid internalformats for CopyTexImage2D were updated in the WebGL 2 conformance tests here: https://github.com/KhronosGroup/WebGL/pull/2226
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4891a30ea3f5b6222c42595c9be931e8e8d47db

commit f4891a30ea3f5b6222c42595c9be931e8e8d47db
Author: Austin Eng <enga@chromium.org>
Date: Fri Nov 16 04:42:57 2018

Roll WebGL 0d55c88..5b6cbd7

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/0d55c88..5b6cbd7

Include suppressions for the following failures:

  conformance2/textures/misc/copy-texture-image.html
On Mac Intel:
  deqp/functional/gles3/framebufferblit/rect_03.html
  deqp/functional/gles3/framebufferblit/rect_04.html

Bug:  905531 , 830046, 658724
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng
Change-Id: I61d36e9ffab9461ee81cce80f320ab9df095f408
Reviewed-on: https://chromium-review.googlesource.com/c/1335270
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608663}
[modify] https://crrev.com/f4891a30ea3f5b6222c42595c9be931e8e8d47db/DEPS
[modify] https://crrev.com/f4891a30ea3f5b6222c42595c9be931e8e8d47db/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/f4891a30ea3f5b6222c42595c9be931e8e8d47db/content/test/gpu/gpu_tests/webgl_conformance_revision.txt

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eced3d15f7514cc42c55709d8490b1f3e1bb785

commit 7eced3d15f7514cc42c55709d8490b1f3e1bb785
Author: Austin Eng <enga@chromium.org>
Date: Wed Nov 28 04:46:10 2018

Fix WebGL conformance2/textures/misc/copy-texture-image.html test

Add additional internal formats for CopyTexImage2D
Unsuppresses previously failing test

# for webgl2_conformance_expectations.py

Bug:  905531 
Change-Id: Ib9f525afa0188def6464c9f6134efc0090825f6b
TBR: kbr@chromium.org
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1340369
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611562}
[modify] https://crrev.com/7eced3d15f7514cc42c55709d8490b1f3e1bb785/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/7eced3d15f7514cc42c55709d8490b1f3e1bb785/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc

Owner: enga@chromium.org
Status: Fixed (was: Available)
Thanks Austin for picking this up. Assigning and marking fixed. Please change if this was wrong.

Sign in to add a comment