Steven, Mike, any idea how we can add 'DCHECK_ALWAYS_ON' to the test binaries that end up on the device?

such as:
jpeg_decode_accelerator_unittest
jpeg_encode_accelerator_unittest
video_decode_accelerator_unittest
video_encode_accelerator_unittest

I guess we'd have to run gn gen (https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/master/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild#981) twice, once with dcheck_always_on=true, and once false.

For the former, we'd have to run chrome_make (https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/master/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild#1054) with chrome_targets only containing the above unittest binaries, and for the latter the rest of targets, including main chrome target.

Deploying should work in the same way/should not require changes (the binaries would still be in out/Release).

This means we'd have to compile (but not link) twice. For performance, my guess would be that dchecks' impact should be negligible.

It may also be interesting to run all unittests with this, not only video ones.

+bpastene@

The problem with the DCHECK is that it will terminate the test run and it won't detect any more failures after that. So on its own it is great at making itself obsolete. A better way would be to fail the test in which the DCHECK happened - with a meaningful log message - and continue testing all following test cases.

It does indeed seem to abort the full run, rather than a single testcase.

I would argue though that it's still useful. I'dd rather miss some test results, than having a potential dangerous bug slip through. In this case we found a failing DCHECK that had gone unnoticed for quite some time, and was actually pointing at a memory leak.

Usually these failures would be caught by pre-submit checks, in which case it's acceptable to abort the test run. Hopefully this will remind programmers to always run tests in debug before checking in.

It might be tricky to just make a DCHECK fail the tests, as we want a full stackdump etc.

GPU Triage: Marking assigned as this appears to have an owner.