[Tab loading animation] Change the thickness of the loading indicator |
|||
Issue descriptionMake the height of the loading indicator to 2dp from 3dp. Feedback from bettes is that it's visually chunky. Reducing the height would make it more balanced. The aim also is to reduce the visual distraction. The blue indicator has higher contrast now the placeholder has been changed to a light grey.
,
Nov 15
,
Nov 15
Thanks sky. Your comment via PK was taken on board when we reviewed this yesterday. 1dp height may have issues with accessibility being so thin. There's more refinements to be made to this loader, which we hope will make it less distracting. There's also going to a some extra attention to the loader since it's new. @pbos can we go for 2dp first. Thanks.
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/956b9f66fd9f838c2edded3eab33c5f90962af89 commit 956b9f66fd9f838c2edded3eab33c5f90962af89 Author: Peter Boström <pbos@chromium.org> Date: Thu Nov 15 21:59:56 2018 Reduce the tab-animation throbber height Bug: chromium:905515 Change-Id: I99ee7721c56583b8bf0cdc48a06d05371f8c4c4b Reviewed-on: https://chromium-review.googlesource.com/c/1337828 Reviewed-by: Sidney San Martín <sdy@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#608532} [modify] https://crrev.com/956b9f66fd9f838c2edded3eab33c5f90962af89/chrome/browser/ui/views/tabs/tab_icon.cc
,
Nov 15
Yep. This looks a lot more subtle, I like it. Soon in a Canary near you. |
|||
►
Sign in to add a comment |
|||
Comment 1 by sky@google.com
, Nov 15