New issue
Advanced search Search tips

Issue 905512 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove bubble_opener parameter from LoginBubble to LoginBaseBubbleView

Project Member Reported by qnnguyen@chromium.org, Nov 15

Issue description

This will make it easier for each bubble view to manage its own focus and event handling behavior in the future.
 
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f757c66024f6c523b56cd91818013349ef351e2

commit 9f757c66024f6c523b56cd91818013349ef351e2
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Thu Nov 15 20:08:26 2018

cros: Move bubble opener parameter into LoginBaseBubbleView

Removes another stateful component of LoginBubble to make it easier to
refactor in subsequent CLs.

Bug:  905512 
Change-Id: If3dca30e9bb531ca1acb829e79db07be6f86d3d8
Reviewed-on: https://chromium-review.googlesource.com/c/1336969
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608484}
[modify] https://crrev.com/9f757c66024f6c523b56cd91818013349ef351e2/ash/login/ui/login_base_bubble_view.cc
[modify] https://crrev.com/9f757c66024f6c523b56cd91818013349ef351e2/ash/login/ui/login_base_bubble_view.h
[modify] https://crrev.com/9f757c66024f6c523b56cd91818013349ef351e2/ash/login/ui/login_bubble.cc
[modify] https://crrev.com/9f757c66024f6c523b56cd91818013349ef351e2/ash/login/ui/login_bubble.h
[modify] https://crrev.com/9f757c66024f6c523b56cd91818013349ef351e2/ash/login/ui/login_bubble_unittest.cc
[modify] https://crrev.com/9f757c66024f6c523b56cd91818013349ef351e2/ash/login/ui/login_expanded_public_account_view.cc
[modify] https://crrev.com/9f757c66024f6c523b56cd91818013349ef351e2/ash/login/ui/login_menu_view.cc
[modify] https://crrev.com/9f757c66024f6c523b56cd91818013349ef351e2/ash/login/ui/login_menu_view.h

Status: Fixed (was: Assigned)

Sign in to add a comment