New issue
Advanced search Search tips

Issue 905508 link

Starred by 1 user
Status: Assigned
Owner:
robliao@chromium.org
Cc:
tapted@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Enable OmniboxPopupContentsViewTest.ClickOmnibox on Mac

Project Member Reported by pkasting@chromium.org, Nov 15 
OmniboxPopupContentsViewTest.ClickOmnibox currently fails on Mac; the sanity check fails.

The EventGeneratorDelegate coordinate mapping stuff on Mac is strange.  I think Mac needs to move to be more like Windows and use screen-relative coordinates in the functions that expect them, instead of using window-relative coordinates instead.

->Rob since Trent is on leave
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dc6204209f6b627ac9b3040c6be34c8506b8a52

commit 1dc6204209f6b627ac9b3040c6be34c8506b8a52
Author: Peter Kasting <pkasting@chromium.org>
Date: Tue Nov 27 23:48:41 2018

Fix and re-enable disabled tests in c/b/ui/views/omnibox/.

These pass on Windows.

Bug: 824418, 905508
Change-Id: Ib6420284643a430cc43a76de3afbb5c2e3de6099
Reviewed-on: https://chromium-review.googlesource.com/c/1333119
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611421}
[modify] https://crrev.com/1dc6204209f6b627ac9b3040c6be34c8506b8a52/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view_browsertest.cc
[modify] https://crrev.com/1dc6204209f6b627ac9b3040c6be34c8506b8a52/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
►

Sign in to add a comment