New issue
Advanced search Search tips
Starred by 33 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----

Blocked on: View detail
issue 915956
issue 922736
issue 930988
issue 930991
issue 923841



Sign in to add a comment
link

Issue 905491: Tab Groups

Reported by tbergquist@google.com, Nov 14 Project Member

Issue description

Feature description: Users can organize tabs into visually distinct groups, e.g. to separate tabs associated with different tasks.

Eng owner: bsep@
Product owner: markchang@

Design doc: go/chrome-tab-groups-design

Are you planning on experimenting before launch? no
Any new strings? yes
Any implications for Google webservices (i.e. sync, translate)? no
Binary size? no
Do the existing perf tests exercise all aspects of your new feature(s)? no
 

Comment 1 by bsep@chromium.org, Nov 14

Description: Show this description

Comment 2 by robliao@chromium.org, Nov 17

Labels: Hotlist-DesktopUITriaged

Comment 3 by robliao@chromium.org, Nov 22

Labels: Group-Tabstrip

Comment 4 by craigtumblison@chromium.org, Nov 29

Labels: Hotlist-ConOps

Comment 6 by robliao@chromium.org, Dec 11

Labels: Pri-1 M-73 Target-73

Comment 7 by aidrees@google.com, Dec 15

Labels: Hotlist-ConOps-CrOS

Comment 8 by bugdroid1@chromium.org, Jan 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fe0c80170d8f8b5848af1b5136588e497890d08

commit 7fe0c80170d8f8b5848af1b5136588e497890d08
Author: Taylor Bergquist <tbergquist@chromium.org>
Date: Wed Jan 09 03:47:20 2019

Implement tab context menu option to add tab(s) to new group.
go/chrome-tab-groups-design

This CL is part of the prototype of the above-described tab groups
feature.  The prototype will allow users to create and manipulate groups
primarily via tab context menus, and will display tab group affiliation
in the tabstrip.  Future work will include persisting and syncing groups,
manipulating groups via tab dragging, and a dropdown menu for the group
headers.

Adds a new class, TabGroupData, to model a tab group, and an association
between tabs and their groups in TabStripModel via a new field in
WebContentsData.  Adds a new entry to the tab's context menu to add the
tab(s) to a new group.

Bug: 905491
Change-Id: I0bccd90326c822fbca92e8544051995ea291a332
Reviewed-on: https://chromium-review.googlesource.com/c/1362435
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621037}
[modify] https://crrev.com/7fe0c80170d8f8b5848af1b5136588e497890d08/chrome/app/generated_resources.grd
[add] https://crrev.com/7fe0c80170d8f8b5848af1b5136588e497890d08/chrome/app/generated_resources_grd/IDS_TAB_CXMENU_ADD_TAB_TO_NEW_GROUP.png.sha1
[modify] https://crrev.com/7fe0c80170d8f8b5848af1b5136588e497890d08/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/7fe0c80170d8f8b5848af1b5136588e497890d08/chrome/browser/ui/tabs/tab_group_data.cc
[add] https://crrev.com/7fe0c80170d8f8b5848af1b5136588e497890d08/chrome/browser/ui/tabs/tab_group_data.h
[modify] https://crrev.com/7fe0c80170d8f8b5848af1b5136588e497890d08/chrome/browser/ui/tabs/tab_menu_model.cc
[modify] https://crrev.com/7fe0c80170d8f8b5848af1b5136588e497890d08/chrome/browser/ui/tabs/tab_strip_model.cc
[modify] https://crrev.com/7fe0c80170d8f8b5848af1b5136588e497890d08/chrome/browser/ui/tabs/tab_strip_model.h
[modify] https://crrev.com/7fe0c80170d8f8b5848af1b5136588e497890d08/chrome/browser/ui/tabs/tab_strip_model_unittest.cc
[modify] https://crrev.com/7fe0c80170d8f8b5848af1b5136588e497890d08/tools/metrics/actions/actions.xml

Comment 9 by tbergquist@google.com, Jan 16

Blockedon: 922736

Comment 10 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4455958e24c4603b1156a53fb57869d16245ec5e

commit 4455958e24c4603b1156a53fb57869d16245ec5e
Author: Taylor Bergquist <tbergquist@chromium.org>
Date: Thu Jan 17 02:45:36 2019

Add context menu submenu to add tab to existing tab group.

Reuses (and slightly simplifies) some of the logic used to add tabs to
new tab groups.

This CL is part of the prototype of the above-described tab groups
feature.  The prototype will allow users to create and manipulate groups
primarily via tab context menus, and will display tab group affiliation
in the tabstrip.  Future work will include persisting and syncing groups,
manipulating groups via tab dragging, and a dropdown menu for the group
headers. See go/chrome-tab-groups-design

Bug: 905491

Change-Id: Id36b896ab5e1cfb51f85b6e1f4fb931670fa2ff1
Reviewed-on: https://chromium-review.googlesource.com/c/1406292
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623533}
[modify] https://crrev.com/4455958e24c4603b1156a53fb57869d16245ec5e/chrome/app/generated_resources.grd
[add] https://crrev.com/4455958e24c4603b1156a53fb57869d16245ec5e/chrome/app/generated_resources_grd/IDS_TAB_CXMENU_ADD_TAB_TO_EXISTING_GROUP.png.sha1
[modify] https://crrev.com/4455958e24c4603b1156a53fb57869d16245ec5e/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/4455958e24c4603b1156a53fb57869d16245ec5e/chrome/browser/ui/tabs/existing_tab_group_sub_menu_model.cc
[add] https://crrev.com/4455958e24c4603b1156a53fb57869d16245ec5e/chrome/browser/ui/tabs/existing_tab_group_sub_menu_model.h
[modify] https://crrev.com/4455958e24c4603b1156a53fb57869d16245ec5e/chrome/browser/ui/tabs/tab_group_data.cc
[modify] https://crrev.com/4455958e24c4603b1156a53fb57869d16245ec5e/chrome/browser/ui/tabs/tab_menu_model.cc
[modify] https://crrev.com/4455958e24c4603b1156a53fb57869d16245ec5e/chrome/browser/ui/tabs/tab_menu_model.h
[modify] https://crrev.com/4455958e24c4603b1156a53fb57869d16245ec5e/chrome/browser/ui/tabs/tab_strip_model.cc
[modify] https://crrev.com/4455958e24c4603b1156a53fb57869d16245ec5e/chrome/browser/ui/tabs/tab_strip_model.h
[modify] https://crrev.com/4455958e24c4603b1156a53fb57869d16245ec5e/chrome/browser/ui/tabs/tab_strip_model_unittest.cc
[modify] https://crrev.com/4455958e24c4603b1156a53fb57869d16245ec5e/tools/metrics/actions/actions.xml

Comment 11 by bugdroid, Jan 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d70dcdcf0a7fac7747a2f5c679312a32ae0a3f3

commit 0d70dcdcf0a7fac7747a2f5c679312a32ae0a3f3
Author: Taylor Bergquist <tbergquist@chromium.org>
Date: Tue Jan 22 21:12:15 2019

Delete tab groups when they become empty.

This CL also explicitly ungroups tabs before they're added to a
different group. This greatly simplifies AddToNewGroup, since it no
longer needs to account for the possibility that the leftmost tab is
already in a group.

This CL is part of the prototype of the above-described tab groups
feature.  The prototype will allow users to create and manipulate groups
primarily via tab context menus, and will display tab group affiliation
in the tabstrip.  Future work will include persisting and syncing groups,
manipulating groups via tab dragging, and a dropdown menu for the group
headers. See go/chrome-tab-groups-design

Bug: 905491
Change-Id: Ib63ed7c45c732b29b9af4ba45edd0393108c5582
Reviewed-on: https://chromium-review.googlesource.com/c/1419250
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Auto-Submit: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624918}
[modify] https://crrev.com/0d70dcdcf0a7fac7747a2f5c679312a32ae0a3f3/chrome/browser/ui/tabs/tab_strip_model.cc
[modify] https://crrev.com/0d70dcdcf0a7fac7747a2f5c679312a32ae0a3f3/chrome/browser/ui/tabs/tab_strip_model.h
[modify] https://crrev.com/0d70dcdcf0a7fac7747a2f5c679312a32ae0a3f3/chrome/browser/ui/tabs/tab_strip_model_unittest.cc

Comment 12 by bugdroid, Jan 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e01942d2eb197018a7a60a2fbde913f0ce944ae2

commit e01942d2eb197018a7a60a2fbde913f0ce944ae2
Author: Bret Sepulveda <bsep@chromium.org>
Date: Tue Jan 29 01:05:18 2019

[Tab Groups] Move Tab::hover_controller_ into TabStyle.

To support Tab-shaped group headers, this patch moves Tab's instance of
GlowHoverController into TabStyle to share it with the new View (coming
in a later patch).

Bug: 905491
Change-Id: I679ddccd77840b25a09c871a132afee390116295
Reviewed-on: https://chromium-review.googlesource.com/c/1423338
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626822}
[modify] https://crrev.com/e01942d2eb197018a7a60a2fbde913f0ce944ae2/chrome/browser/ui/ash/tab_scrubber.cc
[modify] https://crrev.com/e01942d2eb197018a7a60a2fbde913f0ce944ae2/chrome/browser/ui/views/tabs/glow_hover_controller.cc
[modify] https://crrev.com/e01942d2eb197018a7a60a2fbde913f0ce944ae2/chrome/browser/ui/views/tabs/glow_hover_controller.h
[modify] https://crrev.com/e01942d2eb197018a7a60a2fbde913f0ce944ae2/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/e01942d2eb197018a7a60a2fbde913f0ce944ae2/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/e01942d2eb197018a7a60a2fbde913f0ce944ae2/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/e01942d2eb197018a7a60a2fbde913f0ce944ae2/chrome/browser/ui/views/tabs/tab_style.cc
[modify] https://crrev.com/e01942d2eb197018a7a60a2fbde913f0ce944ae2/chrome/browser/ui/views/tabs/tab_style.h

Comment 13 by bsep@chromium.org, Jan 29

Blockedon: 923841

Comment 14 by bsep@chromium.org, Jan 29

Blockedon: 915956

Comment 15 by bugdroid, Jan 31

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41783f0331aa396e7bead0fcf9935f96339411fc

commit 41783f0331aa396e7bead0fcf9935f96339411fc
Author: Bret Sepulveda <bsep@chromium.org>
Date: Thu Jan 31 23:09:57 2019

[Tab Groups] Add new View for group headers with placeholder appearance.

This patch adds the skeleton of a new View for tab group headers. The
View draws as a blue rectangle, with a placeholder title and a button
that does nothing. Usage and polish will be added in later patches.

Bug: 905491
Change-Id: I0cd56ea2e4205d5b7730f632f8f85ca4162d56b5
Reviewed-on: https://chromium-review.googlesource.com/c/1448740
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628129}
[modify] https://crrev.com/41783f0331aa396e7bead0fcf9935f96339411fc/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/41783f0331aa396e7bead0fcf9935f96339411fc/chrome/browser/ui/views/tabs/tab_group_header.cc
[add] https://crrev.com/41783f0331aa396e7bead0fcf9935f96339411fc/chrome/browser/ui/views/tabs/tab_group_header.h

Comment 16 by bsep@chromium.org, Feb 6

Owner: bsep@chromium.org

Comment 17 by bsep@chromium.org, Feb 12

Blockedon: 930988

Comment 18 by bsep@chromium.org, Feb 12

Blockedon: 930991

Sign in to add a comment