New issue
Advanced search Search tips

Issue 905475 link

Starred by 2 users
Status: Assigned
Owner:
allenwebb@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Task

Blocked on:
issue 921231
issue 874977


Sign in to add a comment

Provide a way to force protoc to build protos with the full runtime

Project Member Reported by allenwebb@google.com, Nov 14 
This upstream change provides protoc support for this feature:
https://github.com/protocolbuffers/protobuf/commit/375d32d3eb5d91c10542ebc13252f95249e67714

1) This change needs to be present on Chrome OS
a) protobuf needs to be upreved to 3.6.1
b) afterward it can be upreved to either HEAD or the tag that comes after 3.6.1

2) There needs to be a way of using this feature when building protobufs for fuzz targets that use libprotobuf-mutator.

Comment 1 by allenwebb@google.com, Nov 15

Blockedon: 874977
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/11aba77d7689047e3bb5fb9a5c0baebd34dc1501

commit 11aba77d7689047e3bb5fb9a5c0baebd34dc1501
Author: Allen Webb <allenwebb@google.com>
Date: Mon Nov 19 07:21:09 2018

system_api: Set ebuild to rebuild when protobuf is upgraded.

The output of protoc is tied to a particular version of protobuf so
those files need to be regenerated and anything that uses them
recompiled whenever a newer version of protoc is installed.

BUG=chromium:905475
TEST=sudo emerge system_api

Change-Id: If048765f4f6796b40d193de210f9b408e59311cf
Reviewed-on: https://chromium-review.googlesource.com/1340770
Commit-Ready: Allen Webb <allenwebb@google.com>
Tested-by: Allen Webb <allenwebb@google.com>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/11aba77d7689047e3bb5fb9a5c0baebd34dc1501/chromeos-base/system_api/system_api-9999.ebuild
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a5722d1ee7bae5185d4f836dc9c21bc1807e2a5a

commit a5722d1ee7bae5185d4f836dc9c21bc1807e2a5a
Author: Allen Webb <allenwebb@google.com>
Date: Mon Nov 19 07:21:08 2018

Set ebuilds to rebuild when protobuf is upgraded.

The output of protoc is tied to a particular version of protobuf so
those files need to be regenerated and anything that uses them
recompiled whenever a newer version of protoc is installed.

BUG=chromium:905475
TEST=Passes PreCQ

Change-Id: I3e5b694ca6e233fa1421aa9ed0d675198c3d69cb
Reviewed-on: https://chromium-review.googlesource.com/1340775
Commit-Ready: Allen Webb <allenwebb@google.com>
Tested-by: Allen Webb <allenwebb@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a5722d1ee7bae5185d4f836dc9c21bc1807e2a5a/chromeos-base/chaps/chaps-9999.ebuild
[modify] https://crrev.com/a5722d1ee7bae5185d4f836dc9c21bc1807e2a5a/chromeos-base/cryptohome/cryptohome-9999.ebuild
[rename] https://crrev.com/a5722d1ee7bae5185d4f836dc9c21bc1807e2a5a/app-emulation/lxd/lxd-3.0.2-r5.ebuild
[modify] https://crrev.com/a5722d1ee7bae5185d4f836dc9c21bc1807e2a5a/chromeos-base/mist/mist-9999.ebuild
[modify] https://crrev.com/a5722d1ee7bae5185d4f836dc9c21bc1807e2a5a/app-emulation/lxd/lxd-3.0.2.ebuild
[modify] https://crrev.com/a5722d1ee7bae5185d4f836dc9c21bc1807e2a5a/chromeos-base/wimax_manager/wimax_manager-9999.ebuild
[rename] https://crrev.com/a5722d1ee7bae5185d4f836dc9c21bc1807e2a5a/sys-apps/usbguard/usbguard-20181025-r1.ebuild
[modify] https://crrev.com/a5722d1ee7bae5185d4f836dc9c21bc1807e2a5a/chromeos-base/arc-networkd/arc-networkd-9999.ebuild
[modify] https://crrev.com/a5722d1ee7bae5185d4f836dc9c21bc1807e2a5a/chromeos-base/metrics/metrics-9999.ebuild
[modify] https://crrev.com/a5722d1ee7bae5185d4f836dc9c21bc1807e2a5a/chromeos-base/authpolicy/authpolicy-9999.ebuild
[modify] https://crrev.com/a5722d1ee7bae5185d4f836dc9c21bc1807e2a5a/chromeos-base/modemfwd/modemfwd-9999.ebuild
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9303db9748d1def9044099c939cff17fd68ed439

commit 9303db9748d1def9044099c939cff17fd68ed439
Author: Allen Webb <allenwebb@google.com>
Date: Wed Nov 21 02:27:28 2018

Move dev-libs/grpc to net-libs/grpc for consistency with portage-stable.

This is in preparation of upreving protobuf.

CQ-DEPEND=CL:*717400
BUG=chromium:905475
TEST=PreCQ passes.

Change-Id: Ifb7c42c0442c0c680f31b6e47bb191a0795225cb
Reviewed-on: https://chromium-review.googlesource.com/1338307
Commit-Ready: Allen Webb <allenwebb@google.com>
Tested-by: Allen Webb <allenwebb@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/9303db9748d1def9044099c939cff17fd68ed439/chromeos-base/termina_container_tools/termina_container_tools-0.0.1-r13.ebuild
[rename] https://crrev.com/9303db9748d1def9044099c939cff17fd68ed439/chromeos/config/env/net-libs/grpc
[rename] https://crrev.com/9303db9748d1def9044099c939cff17fd68ed439/net-libs/grpc/files/0002-grpc-1.3.0-Fix-cross-compiling.patch
[rename] https://crrev.com/9303db9748d1def9044099c939cff17fd68ed439/net-libs/grpc/files/0004-grpc-1.3.0-Support-vsock.patch
[modify] https://crrev.com/9303db9748d1def9044099c939cff17fd68ed439/chromeos-base/system_api/system_api-9999.ebuild
[rename] https://crrev.com/9303db9748d1def9044099c939cff17fd68ed439/net-libs/grpc/files/0005-grpc-1.3.0-Don-t-run-ldconfig.patch
[modify] https://crrev.com/9303db9748d1def9044099c939cff17fd68ed439/chromeos-base/vm_host_tools/vm_host_tools-9999.ebuild
[rename] https://crrev.com/9303db9748d1def9044099c939cff17fd68ed439/net-libs/grpc/grpc-1.3.0-r3.ebuild
[rename] https://crrev.com/9303db9748d1def9044099c939cff17fd68ed439/net-libs/grpc/Manifest
[rename] https://crrev.com/9303db9748d1def9044099c939cff17fd68ed439/net-libs/grpc/files/0006-grpc-1.3.0-unused-variable.patch
[modify] https://crrev.com/9303db9748d1def9044099c939cff17fd68ed439/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1.ebuild
[modify] https://crrev.com/9303db9748d1def9044099c939cff17fd68ed439/chromeos-base/termina_container_tools/termina_container_tools-0.0.1.ebuild
[rename] https://crrev.com/9303db9748d1def9044099c939cff17fd68ed439/net-libs/grpc/files/0001-grpc-1.3.0-Fix-incorrect-sonames-and-library-path.patch
[modify] https://crrev.com/9303db9748d1def9044099c939cff17fd68ed439/chromeos-base/diagnostics/diagnostics-9999.ebuild
[rename] https://crrev.com/9303db9748d1def9044099c939cff17fd68ed439/net-libs/grpc/files/0003-grpc-1.3.0-Fix-unsecure-.pc-files.patch
[modify] https://crrev.com/9303db9748d1def9044099c939cff17fd68ed439/chromeos-base/vm_guest_tools/vm_guest_tools-9999.ebuild
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0281be23f73df80d939432e86dd8f3c782c5cdb4

commit 0281be23f73df80d939432e86dd8f3c782c5cdb4
Author: Allen Webb <allenwebb@google.com>
Date: Sat Dec 29 13:45:29 2018

libtpmcrypto: Use fPIC when building proto library for .so.

fPIC is required when building proto libraries that are included in
shared libraries. This adds it to fix a compiler error that shows up
after upreving protobuf.

BUG=chromium:905475
TEST=FEATURES=test emerge-${BOARD} libtpmcrypto

Change-Id: I0cd0f4e871ce708069eeb6cc2c02b33f23a239d1
Reviewed-on: https://chromium-review.googlesource.com/1392148
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Allen Webb <allenwebb@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/0281be23f73df80d939432e86dd8f3c782c5cdb4/libtpmcrypto/BUILD.gn
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/26e199b3184e87e45137184dc5569662c7c52367

commit 26e199b3184e87e45137184dc5569662c7c52367
Author: Allen Webb <allenwebb@google.com>
Date: Thu Jan 03 23:04:27 2019

trunks: Use fPIC when building proto library for .so.

fPIC is required when building proto libraries that are included in
shared libraries. This adds it to fix a compiler error that shows up
after upreving protobuf.

BUG=chromium:905475
TEST=FEATURES=test emerge-${BOARD} trunks

Change-Id: I3edcb141a6caf95e6a9361dec6375c5c146c162d
Reviewed-on: https://chromium-review.googlesource.com/1393046
Commit-Ready: Allen Webb <allenwebb@google.com>
Tested-by: Allen Webb <allenwebb@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/26e199b3184e87e45137184dc5569662c7c52367/trunks/trunks.gyp
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c4167e117eba1d52c9b146d57c4676f436de6403

commit c4167e117eba1d52c9b146d57c4676f436de6403
Author: Allen Webb <allenwebb@google.com>
Date: Thu Jan 03 23:04:12 2019

libtpmcrypto: Set ebuild to rebuild when protobuf is upgraded.

The output of protoc is tied to a particular version of protobuf so
those files need to be regenerated and anything that uses them
recompiled whenever a newer version of protoc is installed.

BUG=chromium:905475
TEST=sudo emerge libtpmcrypto

Change-Id: I4c7aa61a8dd87e5f80b54012adb8b000c635c08a
Reviewed-on: https://chromium-review.googlesource.com/1392046
Commit-Ready: Allen Webb <allenwebb@google.com>
Tested-by: Allen Webb <allenwebb@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c4167e117eba1d52c9b146d57c4676f436de6403/chromeos-base/libtpmcrypto/libtpmcrypto-9999.ebuild
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6a0c4bf5c9cfe6a630872fd2a42311313e41f9c5

commit 6a0c4bf5c9cfe6a630872fd2a42311313e41f9c5
Author: Allen Webb <allenwebb@google.com>
Date: Thu Jan 03 23:04:12 2019

trunks: Set ebuild to rebuild when protobuf is upgraded.

The output of protoc is tied to a particular version of protobuf so
those files need to be regenerated and anything that uses them
recompiled whenever a newer version of protoc is installed.

BUG=chromium:905475
TEST=emerge-${BOARD} trunks

Change-Id: I3baeff24be2ea0f3ba655916d7818c6937aeae61
Reviewed-on: https://chromium-review.googlesource.com/1393257
Commit-Ready: Allen Webb <allenwebb@google.com>
Tested-by: Allen Webb <allenwebb@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/6a0c4bf5c9cfe6a630872fd2a42311313e41f9c5/chromeos-base/trunks/trunks-9999.ebuild

Comment 11 by allenwebb@google.com, Jan 11

Blockedon: 921231
►

Sign in to add a comment