New issue
Advanced search Search tips

Issue 905473 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 915609
Owner:
Closed: Jan 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Tab mirroring tab indicator is black, should be blue

Project Member Reported by dbbrooks@chromium.org, Nov 14

Issue description

Chrome: 72.0.3608.4
MR: 7218.1112.0.0
OS: Mac

What steps will reproduce the problem?
(1) Cast a tab (tab mirroring) E.g. google.com to a Chromecast device.

What is the expected result? Tab mirroring tab indicator should be blue. 

What happens instead? Tab mirroring tab indicator is black. 


Screenshot attached.
Happens for both WebUI and Harmony.
Doesn't happen in M71
 
blackTabIndicator.png
10.7 KB View Download
Labels: OS-Windows
Cc: pbos@chromium.org
I didn't see anything obviously wrong in the tab drawing code, but it's possibly related to recent changes for touch UI, or tab throbber UI (CC pbos@ as an FYI).

Possible to bisect to a revision range?


I should be able to bisect. I'll update tomorrow AM.
Thanks, keep me in the loop. :)
Here's the bisect details. Description of the CL is "Removed hard-coded color from tab_media_capturing icon." :)

You are probably looking for a change made after 606944 (known good), but no later than 606945 (first known bad).

CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/1ec65ecb8bdf7984d02663faed8e17c953ca2521..7762ab842197ba5815e974f3b125b43eed1c02b6
Cc: kylixrd@chromium.org
Cc: taku...@chromium.org
Owner: amyroberts@chromium.org
Status: Assigned (was: Untriaged)
Amy, what's the expected behavior here? Should the indicator always be blue, or change its color depending on the theme?
IIUC after kylixrd@'s change this now uses the same color as the audio indicator.
audio_indicators.png
11.5 KB View Download
The tab mirroring indicator icon is blue again with 73.0.3665.0. Note that the audio indicator is still gray.
Mergedinto: 915609
Status: Duplicate (was: Assigned)
This is the same issue as 915609. Another CL is in the works to fix the audio indicator (https://crrev.com/c/1398286)

Sign in to add a comment