New issue
Advanced search Search tips

Issue 905463 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: !!(flags & HitTestRegionFlags::kHitTestAsk) == !!async_hit_test_reasons in aggre

Project Member Reported by ClusterFuzz, Nov 14

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5713314958802944

Fuzzer: libFuzzer_hit_test_query_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !!(flags & HitTestRegionFlags::kHitTestAsk) == !!async_hit_test_reasons in aggre
  viz::AggregatedHitTestRegion::AggregatedHitTestRegion
  hit_test_query_fuzzer.cc
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=607980:607986

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5713314958802944

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 14

Components: Internals>Compositing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 14

Cc: sadrul@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Nov 14

Labels: Test-Predator-Auto-Owner
Owner: sunxd@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/567005d56ccb3072bd723c3422997d0c42546b69 (Add viz hit test surface layer metrics).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
I think this is due to a missing logic in hit test fuzzer and it somehow generates a hit test region with kHitTestAsk flag but no reason. I'm looking at it.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/938ba0e6c930eef6993b4b5aa35da5e5d31b16a3

commit 938ba0e6c930eef6993b4b5aa35da5e5d31b16a3
Author: Xianda Sun <sunxd@chromium.org>
Date: Thu Nov 15 18:56:05 2018

Fix viz hit testing clusterfuzz issue

Because the hit test query fuzzer generates hit test flags and async hit
test reasons independently, it sometimes triggers a DCHECK that verifies
correct reasons have been set when there is an asynchronous hit testing
being performed.

This CL fixes it by generating non-kNotAsycnHitTest reasons only when
the fuzz flags contain kHitTestAsk.

Bug:  905463 
Change-Id: Ibf73d7138951af93b7fe2029242d6e062ff1a11d
Reviewed-on: https://chromium-review.googlesource.com/c/1338139
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608447}
[modify] https://crrev.com/938ba0e6c930eef6993b4b5aa35da5e5d31b16a3/components/viz/host/hit_test/hit_test_query_fuzzer.cc

Status: Fixed (was: Assigned)
Project Member

Comment 7 by ClusterFuzz, Nov 26

Labels: Needs-Feedback
ClusterFuzz testcase 5713314958802944 is still reproducing on tip-of-tree build (trunk).

Please re-test your fix against this testcase and if the fix was incorrect or incomplete, please re-open the bug. Otherwise, ignore this notification and add ClusterFuzz-Wrong label.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bacac8f7b31b175a3f2743c57f6d79a418665057

commit bacac8f7b31b175a3f2743c57f6d79a418665057
Author: Xianda Sun <sunxd@chromium.org>
Date: Mon Nov 26 17:30:49 2018

Fix hit test query fuzzer

This patch fixes a bug in previous fuzzer patch. We need to use "and"
operand to make sure the flag contains kHitTestAsk.

Bug:  905463 
Change-Id: I13935185756dfef4474b94975bfec833469bdac1
Reviewed-on: https://chromium-review.googlesource.com/c/1351271
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610871}
[modify] https://crrev.com/bacac8f7b31b175a3f2743c57f6d79a418665057/components/viz/host/hit_test/hit_test_query_fuzzer.cc

Project Member

Comment 9 by ClusterFuzz, Nov 27

ClusterFuzz has detected this issue as fixed in range 610868:610873.

Detailed report: https://clusterfuzz.com/testcase?key=5713314958802944

Fuzzer: libFuzzer_hit_test_query_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !!(flags & HitTestRegionFlags::kHitTestAsk) == !!async_hit_test_reasons in aggre
  viz::AggregatedHitTestRegion::AggregatedHitTestRegion
  hit_test_query_fuzzer.cc
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=607980:607986
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=610868:610873

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5713314958802944

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Nov 27

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5713314958802944 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Cc: riajiang@chromium.org sunxd@chromium.org
 Issue 908774  has been merged into this issue.

Sign in to add a comment