Implement the metrics outlined in go/smartlock-metrics.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53001b7cd9bbfb6eafe64693de92b1bdd6278412 commit 53001b7cd9bbfb6eafe64693de92b1bdd6278412 Author: Regan Hsu <hsuregan@chromium.org> Date: Tue Nov 27 18:14:48 2018 [CrOS MultiDevice] Smart Lock: Create stability metrics for unlock. Boolean histograms that capture the success rate for Smart Lock unlock during authentication and connection phase, and enum histograms that breaks down the failure reasons when Smart Lock fails to unlock during authentication and connection phase. Bug: 905438 Change-Id: I4aa35101949931bdd859f886d31e3a78c1412814 Reviewed-on: https://chromium-review.googlesource.com/c/1334227 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#611196} [modify] https://crrev.com/53001b7cd9bbfb6eafe64693de92b1bdd6278412/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/53001b7cd9bbfb6eafe64693de92b1bdd6278412/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h [modify] https://crrev.com/53001b7cd9bbfb6eafe64693de92b1bdd6278412/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc [modify] https://crrev.com/53001b7cd9bbfb6eafe64693de92b1bdd6278412/chromeos/components/proximity_auth/BUILD.gn [modify] https://crrev.com/53001b7cd9bbfb6eafe64693de92b1bdd6278412/chromeos/components/proximity_auth/proximity_auth_system.cc [modify] https://crrev.com/53001b7cd9bbfb6eafe64693de92b1bdd6278412/chromeos/components/proximity_auth/proximity_auth_system.h [modify] https://crrev.com/53001b7cd9bbfb6eafe64693de92b1bdd6278412/chromeos/components/proximity_auth/proximity_auth_system_unittest.cc [add] https://crrev.com/53001b7cd9bbfb6eafe64693de92b1bdd6278412/chromeos/components/proximity_auth/smart_lock_metrics_recorder.cc [add] https://crrev.com/53001b7cd9bbfb6eafe64693de92b1bdd6278412/chromeos/components/proximity_auth/smart_lock_metrics_recorder.h [modify] https://crrev.com/53001b7cd9bbfb6eafe64693de92b1bdd6278412/chromeos/components/proximity_auth/unlock_manager.h [modify] https://crrev.com/53001b7cd9bbfb6eafe64693de92b1bdd6278412/chromeos/components/proximity_auth/unlock_manager_impl.cc [modify] https://crrev.com/53001b7cd9bbfb6eafe64693de92b1bdd6278412/chromeos/components/proximity_auth/unlock_manager_impl.h [modify] https://crrev.com/53001b7cd9bbfb6eafe64693de92b1bdd6278412/tools/metrics/histograms/enums.xml [modify] https://crrev.com/53001b7cd9bbfb6eafe64693de92b1bdd6278412/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbbb99807779dc6296a7993a3fa0fc34e04024bc commit bbbb99807779dc6296a7993a3fa0fc34e04024bc Author: Regan Hsu <hsuregan@chromium.org> Date: Wed Dec 05 22:35:46 2018 [CrOS MultiDevice] Smart Lock: Create stability metrics for Signin. Boolean histograms that capture the success rate for Smart Lock Signin during authentication and connection phase, and enum histograms that breaks down the failure reasons when Smart Lock fails to sign in during authentication and connection phase. Bug: 905438 Change-Id: I12c0e4b38d21101d7819f79a11173655b4c70f8a Reviewed-on: https://chromium-review.googlesource.com/c/1352485 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#614140} [modify] https://crrev.com/bbbb99807779dc6296a7993a3fa0fc34e04024bc/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/bbbb99807779dc6296a7993a3fa0fc34e04024bc/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc [modify] https://crrev.com/bbbb99807779dc6296a7993a3fa0fc34e04024bc/chrome/browser/chromeos/login/screens/user_selection_screen.cc [modify] https://crrev.com/bbbb99807779dc6296a7993a3fa0fc34e04024bc/chromeos/components/proximity_auth/smart_lock_metrics_recorder.cc [modify] https://crrev.com/bbbb99807779dc6296a7993a3fa0fc34e04024bc/chromeos/components/proximity_auth/smart_lock_metrics_recorder.h [modify] https://crrev.com/bbbb99807779dc6296a7993a3fa0fc34e04024bc/chromeos/components/proximity_auth/unlock_manager_impl.cc [modify] https://crrev.com/bbbb99807779dc6296a7993a3fa0fc34e04024bc/tools/metrics/histograms/enums.xml [modify] https://crrev.com/bbbb99807779dc6296a7993a3fa0fc34e04024bc/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6577330efc150881118aab752860170bcb2d4d3b commit 6577330efc150881118aab752860170bcb2d4d3b Author: Regan Hsu <hsuregan@chromium.org> Date: Thu Dec 06 20:00:46 2018 [CrOS MultiDevice] Smart Lock: Metrics for UserControllerAuth Failure An enumerated histogram that breaks down why the UserController could not decrypt the account. This is a breakdown of the previous “UserController sign-in failure” bucket in SmartLock.AuthResult.SignIn.Failure. Bug: 905438 Change-Id: Ie68c19a4f27ba410158d2d0ebe5457ec5d3c02cf Reviewed-on: https://chromium-review.googlesource.com/c/1354312 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#614459} [modify] https://crrev.com/6577330efc150881118aab752860170bcb2d4d3b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_user_login_flow.cc [modify] https://crrev.com/6577330efc150881118aab752860170bcb2d4d3b/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/691cf7460bef6c1af65ad40d192507e63e1674ba commit 691cf7460bef6c1af65ad40d192507e63e1674ba Author: Regan Hsu <hsuregan@chromium.org> Date: Wed Dec 12 21:14:19 2018 [CrOS MultiDevice] Smart Lock Unlock and SignIn Auth method choice. Histograms which records if the user attempted to unlock and signin their device via SL (tapped their user photo) or other auth method (e.g., password, PIN, or fingerprint tba). Bug: 905438 Change-Id: I1cd840c67ad717102b4008be7e92aafcad5f95c6 Reviewed-on: https://chromium-review.googlesource.com/c/1355846 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#616044} [modify] https://crrev.com/691cf7460bef6c1af65ad40d192507e63e1674ba/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/691cf7460bef6c1af65ad40d192507e63e1674ba/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h [modify] https://crrev.com/691cf7460bef6c1af65ad40d192507e63e1674ba/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc [modify] https://crrev.com/691cf7460bef6c1af65ad40d192507e63e1674ba/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.h [modify] https://crrev.com/691cf7460bef6c1af65ad40d192507e63e1674ba/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc [modify] https://crrev.com/691cf7460bef6c1af65ad40d192507e63e1674ba/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.h [modify] https://crrev.com/691cf7460bef6c1af65ad40d192507e63e1674ba/chromeos/components/proximity_auth/smart_lock_metrics_recorder.cc [modify] https://crrev.com/691cf7460bef6c1af65ad40d192507e63e1674ba/chromeos/components/proximity_auth/smart_lock_metrics_recorder.h [modify] https://crrev.com/691cf7460bef6c1af65ad40d192507e63e1674ba/tools/metrics/histograms/enums.xml [modify] https://crrev.com/691cf7460bef6c1af65ad40d192507e63e1674ba/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2565e25cdcda10555118e59a7c19743300dba58b commit 2565e25cdcda10555118e59a7c19743300dba58b Author: Regan Hsu <hsuregan@chromium.org> Date: Thu Dec 13 00:30:41 2018 [CrOS MultiDevice] SmartLock: Password State metrics for SignIn & Unlock Histogram that break down what state Smart Lock was in when the user chose to use their password to unlock and signin their device. Bug: 905438 Change-Id: I801c17ac9872a70423cf1fdc4ca36bb55e0e5824 Reviewed-on: https://chromium-review.googlesource.com/c/1356321 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#616121} [modify] https://crrev.com/2565e25cdcda10555118e59a7c19743300dba58b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/2565e25cdcda10555118e59a7c19743300dba58b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h [modify] https://crrev.com/2565e25cdcda10555118e59a7c19743300dba58b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc [modify] https://crrev.com/2565e25cdcda10555118e59a7c19743300dba58b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc [modify] https://crrev.com/2565e25cdcda10555118e59a7c19743300dba58b/chromeos/components/proximity_auth/smart_lock_metrics_recorder.cc [modify] https://crrev.com/2565e25cdcda10555118e59a7c19743300dba58b/chromeos/components/proximity_auth/smart_lock_metrics_recorder.h [modify] https://crrev.com/2565e25cdcda10555118e59a7c19743300dba58b/tools/metrics/histograms/enums.xml [modify] https://crrev.com/2565e25cdcda10555118e59a7c19743300dba58b/tools/metrics/histograms/histograms.xml
Not fixed yet :) I still need to implement some performance metrics. Assigning back to me.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59bdfdc9aa5cf9148bcd9dcb7cd143111a407443 commit 59bdfdc9aa5cf9148bcd9dcb7cd143111a407443 Author: Ryan Hansberry <hansberry@chromium.org> Date: Thu Jan 10 01:08:35 2019 Smart Lock: Remove misleading auth failure reason metric bucket. The state of "Already attempting auth" isn't a true failure; it means that an attempt was ignored, however, an earlier attempt is being finished. We only want to record the result of that earlier attempt, so do not record a failure in this case. Bug: 905438 Change-Id: Ic8a755c77756e82f997d8dc2f31fa5f98566f8c0 Reviewed-on: https://chromium-review.googlesource.com/c/1385118 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#621400} [modify] https://crrev.com/59bdfdc9aa5cf9148bcd9dcb7cd143111a407443/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/59bdfdc9aa5cf9148bcd9dcb7cd143111a407443/chromeos/components/proximity_auth/smart_lock_metrics_recorder.h [modify] https://crrev.com/59bdfdc9aa5cf9148bcd9dcb7cd143111a407443/chromeos/components/proximity_auth/unlock_manager_impl.cc [modify] https://crrev.com/59bdfdc9aa5cf9148bcd9dcb7cd143111a407443/tools/metrics/histograms/enums.xml
Comment 1 by bugdroid1@chromium.org
, Nov 27