Remove persistence flag from LoginBubble |
||||
Issue descriptionAs part of refactoring Login Bubble, we should remove the flag for deciding whether to show a bubble persistently. This behavior should be a property of the bubble objects themselves rather than a variable we have to mutate every time we show or hide a different bubble.
,
Nov 15
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f29016ee2304c4a46c39393390a58d83bf07d35 commit 1f29016ee2304c4a46c39393390a58d83bf07d35 Author: Kentaro Hara <haraken@chromium.org> Date: Thu Nov 15 06:23:16 2018 Revert "cros: Turn LoginBubble flags into a LoginBaseBubbleView member function" This reverts commit 21216eb00511781a2e2c93de0321e7fcf886024d. Reason for revert: I'm 20% sure but this CL is suspicious for the failure on Linux Chromium OS ASan LSan Tests. Let me try to revert it and see how it goes. If it's innocent, let me reland! https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30100 Original change's description: > cros: Turn LoginBubble flags into a LoginBaseBubbleView member function > > This prevents us from having to mutate the flags variable each time a bubble is > shown or hidden. > > Bug: 905436 > Change-Id: Ia40f2d0b9aa949fd6c67b46dcf22a5e5272f60a7 > Reviewed-on: https://chromium-review.googlesource.com/c/1336254 > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608151} TBR=jdufault@chromium.org,qnnguyen@chromium.org Change-Id: Iebf03b66402b61999a53a1db372fbc36d9a91c0c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905436 Reviewed-on: https://chromium-review.googlesource.com/c/1337141 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#608278} [modify] https://crrev.com/1f29016ee2304c4a46c39393390a58d83bf07d35/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/1f29016ee2304c4a46c39393390a58d83bf07d35/ash/login/ui/login_base_bubble_view.cc [modify] https://crrev.com/1f29016ee2304c4a46c39393390a58d83bf07d35/ash/login/ui/login_base_bubble_view.h [modify] https://crrev.com/1f29016ee2304c4a46c39393390a58d83bf07d35/ash/login/ui/login_bubble.cc [modify] https://crrev.com/1f29016ee2304c4a46c39393390a58d83bf07d35/ash/login/ui/login_bubble.h [modify] https://crrev.com/1f29016ee2304c4a46c39393390a58d83bf07d35/ash/login/ui/login_bubble_unittest.cc
,
Nov 15
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1d8bce1727c530bb2ec624504d9924e86f2ced6 commit f1d8bce1727c530bb2ec624504d9924e86f2ced6 Author: Quan Nguyen <qnnguyen@chromium.org> Date: Mon Nov 19 18:53:05 2018 Reland "cros: Turn LoginBubble flags into a LoginBaseBubbleView member function" This reverts commit 1f29016ee2304c4a46c39393390a58d83bf07d35. The original CL was found not to be the culprit for the test failure. TBR=jdufault@chromium.org Bug: 905436 Change-Id: I750baa17c1d27a2940c3ed050c3f274fc4e8226c Reviewed-on: https://chromium-review.googlesource.com/c/1342762 Reviewed-by: Quan Nguyen <qnnguyen@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609369} [modify] https://crrev.com/f1d8bce1727c530bb2ec624504d9924e86f2ced6/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/f1d8bce1727c530bb2ec624504d9924e86f2ced6/ash/login/ui/login_base_bubble_view.cc [modify] https://crrev.com/f1d8bce1727c530bb2ec624504d9924e86f2ced6/ash/login/ui/login_base_bubble_view.h [modify] https://crrev.com/f1d8bce1727c530bb2ec624504d9924e86f2ced6/ash/login/ui/login_bubble.cc [modify] https://crrev.com/f1d8bce1727c530bb2ec624504d9924e86f2ced6/ash/login/ui/login_bubble.h [modify] https://crrev.com/f1d8bce1727c530bb2ec624504d9924e86f2ced6/ash/login/ui/login_bubble_unittest.cc
,
Nov 20
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Nov 14