Bring up unit_tests with --enable-features=SingleProcessMash |
||||||||
Issue descriptionWe'll need to make sure all these work too. I suspect we'll need to add random calls to AshTestBase::SetRunningOutsideAsh().
,
Nov 16
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8499d4449b8559c9734109c7f032f2f4811a55a commit e8499d4449b8559c9734109c7f032f2f4811a55a Author: Evan Stade <estade@chromium.org> Date: Fri Nov 16 21:17:48 2018 Remove BrowserWithTestWindowTest's AtExitManager. It was added in 2012 for PrintPreviewTest but is no longer needed and is causing issues with single process mash tests, where OzonePlatform only expects to get initialized once. If this happens in a test's SetUp(), and parts of it get destroyed by the AtExitManager, they won't be re- initialized for later tests. Tests will still pass in isolation but not when run as a suite. This CL also simplifies PrintPreviewTest a bit, which is the test fixture for which the AtExitManager was originally added. Bug: 905430 Change-Id: I4617aed098962f4eea6a9d1bfe052e3902278557 Reviewed-on: https://chromium-review.googlesource.com/c/1340798 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#608948} [modify] https://crrev.com/e8499d4449b8559c9734109c7f032f2f4811a55a/chrome/browser/printing/print_preview_test.cc [modify] https://crrev.com/e8499d4449b8559c9734109c7f032f2f4811a55a/chrome/browser/printing/print_preview_test.h [modify] https://crrev.com/e8499d4449b8559c9734109c7f032f2f4811a55a/chrome/browser/printing/print_view_manager_unittest.cc [modify] https://crrev.com/e8499d4449b8559c9734109c7f032f2f4811a55a/chrome/test/base/browser_with_test_window_test.h
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c489f4f41545adab3d4682f0f3c99713a3cb062 commit 0c489f4f41545adab3d4682f0f3c99713a3cb062 Author: Evan Stade <estade@chromium.org> Date: Mon Nov 19 17:57:38 2018 Make ExtensionEventObserverTest a RenderViewHostTestHarness This simplifies the test harness and makes the test pass with single process Mash (due to extra setup performed by the parent test fixture). Bug: 905430 Change-Id: Ic68c5900bc7632dc9177e730706007fb4e3eab39 Reviewed-on: https://chromium-review.googlesource.com/c/1340949 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#609354} [modify] https://crrev.com/0c489f4f41545adab3d4682f0f3c99713a3cb062/chrome/browser/chromeos/power/extension_event_observer_unittest.cc
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c35d1866d89313f949129ebe7f594e6b16b7060 commit 5c35d1866d89313f949129ebe7f594e6b16b7060 Author: Evan Stade <estade@chromium.org> Date: Tue Nov 20 18:20:20 2018 Make PasswordManagerPorterTest a ChromeRenderViewHostTestHarness This simplifies the test fixture and allows the tests to pass in single process mash. (Technically, they also pass in single process mash without this change, but would cease to do so after AuraTestSuite stops creating an InputDeviceClient, which will soon happen.) Bug: 905430 Change-Id: Ie2a08154d28fbe3a17148c3097eb1d2278ae8ef6 Reviewed-on: https://chromium-review.googlesource.com/c/1343293 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#609749} [modify] https://crrev.com/5c35d1866d89313f949129ebe7f594e6b16b7060/chrome/browser/ui/passwords/password_manager_porter_unittest.cc
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dbb458ff9377ba6c510a9ec20a739e85fa055fd commit 5dbb458ff9377ba6c510a9ec20a739e85fa055fd Author: Evan Stade <estade@chromium.org> Date: Tue Nov 20 18:24:10 2018 Make ChromeOmniboxNagivationObserverTest a ChromeRenderViewHostTestHarness This simplifies the test fixture and allows the tests to pass in single process mash. (Technically, they also pass in single process mash without this change, but would cease to do so after AuraTestSuite stops creating an InputDeviceClient, which will soon happen.) Bug: 905430 Change-Id: I067e2e0affcf3f0b95fa687f303882a6233cb1cf Reviewed-on: https://chromium-review.googlesource.com/c/1343341 Reviewed-by: Kevin Bailey <krb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#609751} [modify] https://crrev.com/5dbb458ff9377ba6c510a9ec20a739e85fa055fd/chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer_unittest.cc
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/169bc3fe4f3ac190b78280a549d047b742e13bec commit 169bc3fe4f3ac190b78280a549d047b742e13bec Author: Evan Stade <estade@chromium.org> Date: Tue Nov 20 19:44:40 2018 Make SyncSessionsWebContentsRouterTest a ChromeRenderViewHostTestHarness This simplifies the test fixture and allows the tests to pass in single process mash. (Technically, they also pass in single process mash without this change, but would cease to do so after AuraTestSuite stops creating an InputDeviceClient, which will soon happen.) Bug: 905430 Change-Id: I9536989b016176b96db824732720b86d6442f27d Reviewed-on: https://chromium-review.googlesource.com/c/1343338 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609776} [modify] https://crrev.com/169bc3fe4f3ac190b78280a549d047b742e13bec/chrome/browser/sync/sessions/sync_sessions_web_contents_router_unittest.cc
,
Nov 20
,
Nov 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fdb49805618216b394362b0fad43e26def9e32e commit 0fdb49805618216b394362b0fad43e26def9e32e Author: Evan Stade <estade@chromium.org> Date: Mon Nov 26 21:47:30 2018 Make SyncInternalsMessageHandlerTest a ChromeRenderViewHostTestHarness. This simplifies the test and allows it to pass in single process mash due to extra setup in the test fixture. (Technically, it also passes in single process mash without this change, but would cease to do so after AuraTestSuite stops creating an InputDeviceClient, which will soon happen.) Bug: 905430 Change-Id: Ib85c034c9e83d9c6fbcbcece130401e37621609e Reviewed-on: https://chromium-review.googlesource.com/c/1343283 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#610952} [modify] https://crrev.com/0fdb49805618216b394362b0fad43e26def9e32e/chrome/browser/ui/webui/sync_internals_message_handler_unittest.cc
,
Nov 26
Many single process mash unit tests fail when a renderer is created if an InputDeviceManager isn't created first. Here's the stack: [125631:125631:1126/152553.163834:1201291211023:FATAL:input_device_manager.cc(18)] Check failed: g_instance. InputDeviceManager::SetInstance must be called before getting the instance of InputDeviceManager. #0 0x7f861845cf6f base::debug::StackTrace::StackTrace() #1 0x7f861838d05b logging::LogMessage::~LogMessage() #2 0x7f861269912d ui::InputDeviceManager::GetInstance() #3 0x7f86164b45f0 content::InputDeviceChangeObserver::InputDeviceChangeObserver() #4 0x7f8616542246 content::RenderViewHostImpl::RenderViewHostImpl() #5 0x7f8616541758 content::RenderViewHostFactory::Create() #6 0x7f86162e99d8 content::FrameTree::CreateRenderViewHost() #7 0x7f8616345faf content::RenderFrameHostManager::CreateRenderFrameHost() #8 0x7f8616345e79 content::RenderFrameHostManager::Init() #9 0x7f8616698f0e content::WebContentsImpl::Init() #10 0x5561c75ce41b content::TestWebContents::Create() #11 0x5561c75c86d9 content::WebContentsTester::CreateTestWebContents() #12 0x5561c929bdf3 extensions::TestExtensionEnvironment::MakeTab() #13 0x5561c54d63e8 extensions::(anonymous namespace)::DeclarativeContentActionTest_SetIcon_Test::TestBody() #14 0x5561c6542581 testing::Test::Run() #15 0x5561c65431cf testing::TestInfo::Run() #16 0x5561c65436f7 testing::TestCase::Run() #17 0x5561c654fa67 testing::internal::UnitTestImpl::RunAllTests() #18 0x5561c654f5dd testing::UnitTest::Run() #19 0x5561c753cb31 base::TestSuite::Run() #20 0x5561c753ec6d base::(anonymous namespace)::LaunchUnitTestsInternal() #21 0x5561c753ead1 base::LaunchUnitTests() #22 0x5561c7531ecf main #23 0x7f860b6042b1 __libc_start_main #24 0x5561c46d7b7a _start
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01dd4eadad20e021288a3d8db6302fdff024a092 commit 01dd4eadad20e021288a3d8db6302fdff024a092 Author: Evan Stade <estade@chromium.org> Date: Wed Nov 28 04:12:48 2018 Make BrowserWithTestWindowTests work with single process Mash The InputDeviceClient needs to only be created once, so remove it from AuraTestSuiteSetup. Otherwise, in BrowserWithTestWindowTest, it gets created twice: during test suite setup, and as part of OzonePlatform (due to AshTestHelper/ash::Shell). Many tests still need one though, especially those that create a WebContents, so add it to RenderViewHostTestEnabler, which should take care of all RenderViewHostTestHarness tests or tests that create the enabler manually. Also update a few other tests to either create their own RenderViewHostTestEnabler or InputDeviceClient as appropriate. Also the InputDeviceManager can be a true singleton now (not thread- singleton). Bug: 905430 Change-Id: I2974968efe0415f0b56218e24b4fa546a1524fe1 Reviewed-on: https://chromium-review.googlesource.com/c/1341075 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#611556} [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_unittest.cc [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler_unittest.cc [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/chrome/test/base/browser_with_test_window_test.cc [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/chrome/test/base/browser_with_test_window_test.h [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/content/browser/media/media_internals_unittest.cc [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/content/browser/media/session/media_session_impl_unittest.cc [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/content/public/test/test_renderer_host.cc [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/content/public/test/test_renderer_host.h [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/ui/aura/test/aura_test_suite_setup.cc [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/ui/aura/test/aura_test_suite_setup.h [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/ui/aura/test/aura_test_utils.cc [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/ui/aura/test/aura_test_utils.h [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/ui/events/devices/input_device_manager.cc [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/ui/events/devices/input_device_manager.h [modify] https://crrev.com/01dd4eadad20e021288a3d8db6302fdff024a092/ui/views/controls/webview/webview_unittest.cc
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a060c4e9a5fb35535ba26642df21914dad5ac379 commit a060c4e9a5fb35535ba26642df21914dad5ac379 Author: Darren Shen <shend@chromium.org> Date: Wed Nov 28 04:24:04 2018 Revert "Make BrowserWithTestWindowTests work with single process Mash" This reverts commit 01dd4eadad20e021288a3d8db6302fdff024a092. Reason for revert: Seems to have broken fushcia cast: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-arm64-cast/2910 Original change's description: > Make BrowserWithTestWindowTests work with single process Mash > > The InputDeviceClient needs to only be created once, so remove it > from AuraTestSuiteSetup. Otherwise, in BrowserWithTestWindowTest, > it gets created twice: during test suite setup, and as part of > OzonePlatform (due to AshTestHelper/ash::Shell). > > Many tests still need one though, especially those that create a > WebContents, so add it to RenderViewHostTestEnabler, which should > take care of all RenderViewHostTestHarness tests or tests that create > the enabler manually. > > Also update a few other tests to either create their own > RenderViewHostTestEnabler or InputDeviceClient as appropriate. > > Also the InputDeviceManager can be a true singleton now (not thread- > singleton). > > Bug: 905430 > Change-Id: I2974968efe0415f0b56218e24b4fa546a1524fe1 > Reviewed-on: https://chromium-review.googlesource.com/c/1341075 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611556} TBR=sky@chromium.org,estade@chromium.org Change-Id: Iadad5f76d31d82e8dc4cd427db184f536fdbef38 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905430 Reviewed-on: https://chromium-review.googlesource.com/c/1352125 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#611559} [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_unittest.cc [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler_unittest.cc [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/chrome/test/base/browser_with_test_window_test.cc [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/chrome/test/base/browser_with_test_window_test.h [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/content/browser/media/media_internals_unittest.cc [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/content/browser/media/session/media_session_impl_unittest.cc [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/content/public/test/test_renderer_host.cc [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/content/public/test/test_renderer_host.h [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/ui/aura/test/aura_test_suite_setup.cc [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/ui/aura/test/aura_test_suite_setup.h [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/ui/aura/test/aura_test_utils.cc [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/ui/aura/test/aura_test_utils.h [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/ui/events/devices/input_device_manager.cc [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/ui/events/devices/input_device_manager.h [modify] https://crrev.com/a060c4e9a5fb35535ba26642df21914dad5ac379/ui/views/controls/webview/webview_unittest.cc
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c59338e4a2de81086ecf31697be7cd91b64e19a commit 2c59338e4a2de81086ecf31697be7cd91b64e19a Author: Evan Stade <estade@chromium.org> Date: Wed Nov 28 22:23:19 2018 Make BrowserHistoryHandlerTest a ChromeRenderViewHostTestHarness. This simplifies the test and allows it to pass in single process mash due to extra setup in the test fixture. (Technically, it also passes in single process mash without this change, but would cease to do so after AuraTestSuite stops creating an InputDeviceClient, which will soon happen.) Bug: 905430 Change-Id: I0f9f630fdfd68e72bae1e652bad07bc18ec39d51 Reviewed-on: https://chromium-review.googlesource.com/c/1343348 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#611896} [modify] https://crrev.com/2c59338e4a2de81086ecf31697be7cd91b64e19a/chrome/browser/ui/webui/browsing_history_handler_unittest.cc
,
Nov 29
,
Nov 29
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7591cbc49bf6e29303c6560d42ed53cb9423b9bb commit 7591cbc49bf6e29303c6560d42ed53cb9423b9bb Author: Evan Stade <estade@chromium.org> Date: Fri Nov 30 06:54:29 2018 Bring up more unit_tests for single process Mash. BrowserWithTestWindowTest now creates a MusClient, which is important for its native widget factory. AshTestViewsDelegate doesn't set the context on context/parentless widgets for Mash, since DesktopNativeWidgetAura doesn't require that and it interferes with getting the correct aura::Env. Using Shell's Env is problematic because the aura::Window for a WebContents wants to use aura::Env::GetInstance, which differs from the shell's Env. WebContentsViewAura uses the Env of its context for the aura::Window it creates, if there is a context. Also, spot fixes for: 1. LockScreenAppStateTest 2. ChromeLauncherControllerTest 3. ImmersiveModeControllerAshTest (some of these pass, a couple still fail, but none should crash) 4. TabStripTest 5. BookmarkBarViewTest Bug: 906906 , 905430 Change-Id: I19ce303a0cad91262c1a393379ecd5c9d2bf75fb Reviewed-on: https://chromium-review.googlesource.com/c/1351884 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#612587} [modify] https://crrev.com/7591cbc49bf6e29303c6560d42ed53cb9423b9bb/ash/test/ash_test_views_delegate.cc [modify] https://crrev.com/7591cbc49bf6e29303c6560d42ed53cb9423b9bb/chrome/browser/chromeos/lock_screen_apps/state_controller_unittest.cc [modify] https://crrev.com/7591cbc49bf6e29303c6560d42ed53cb9423b9bb/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc [modify] https://crrev.com/7591cbc49bf6e29303c6560d42ed53cb9423b9bb/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc [modify] https://crrev.com/7591cbc49bf6e29303c6560d42ed53cb9423b9bb/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc [modify] https://crrev.com/7591cbc49bf6e29303c6560d42ed53cb9423b9bb/chrome/browser/ui/views/tabs/tab_strip_unittest.cc [modify] https://crrev.com/7591cbc49bf6e29303c6560d42ed53cb9423b9bb/chrome/test/base/browser_with_test_window_test.cc [modify] https://crrev.com/7591cbc49bf6e29303c6560d42ed53cb9423b9bb/chrome/test/base/browser_with_test_window_test.h [modify] https://crrev.com/7591cbc49bf6e29303c6560d42ed53cb9423b9bb/content/browser/web_contents/web_contents_view_aura.cc
,
Dec 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4909591a828291f6eeda3a755f732ce99c8b52ce commit 4909591a828291f6eeda3a755f732ce99c8b52ce Author: Evan Stade <estade@chromium.org> Date: Mon Dec 03 17:43:42 2018 Fix a unit test for single process mash. - ArcVoiceInteractionFrameworkServiceTest.CapturingScreenshotBlocksIncognitoWindows Bug: 905430 Change-Id: If332da0d0abcd722a82a51c9a84bc39d2c0735e3 Reviewed-on: https://chromium-review.googlesource.com/c/1354678 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#613141} [modify] https://crrev.com/4909591a828291f6eeda3a755f732ce99c8b52ce/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service_unittest.cc
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83d2dcc80b00271e79495694cf2ab073fb139c54 commit 83d2dcc80b00271e79495694cf2ab073fb139c54 Author: Evan Stade <estade@chromium.org> Date: Tue Dec 04 05:04:13 2018 Add SingleProcessMash unit_tests to buildbots, with filter file Bug: 905430 Change-Id: Ie6a7886a351c0ea75c92947bc5a7829762e8bd8c Reviewed-on: https://chromium-review.googlesource.com/c/1355759 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#613418} [modify] https://crrev.com/83d2dcc80b00271e79495694cf2ab073fb139c54/testing/buildbot/chromium.fyi.json [add] https://crrev.com/83d2dcc80b00271e79495694cf2ab073fb139c54/testing/buildbot/filters/chromeos.single_process_mash.fyi.unit_tests.filter [modify] https://crrev.com/83d2dcc80b00271e79495694cf2ab073fb139c54/testing/buildbot/test_suites.pyl
,
Dec 4
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a7ce336361580fe245c4564b57bbcc4481f9137 commit 6a7ce336361580fe245c4564b57bbcc4481f9137 Author: Evan Stade <estade@chromium.org> Date: Tue Dec 04 23:55:57 2018 Add build entries for chromeos.single_process_mash.fyi.unit_tests.filter Bug: 905430 Change-Id: I83bdc0ce72732faff08ed483ac03b1bd24c98a23 Reviewed-on: https://chromium-review.googlesource.com/c/1361833 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#613766} [modify] https://crrev.com/6a7ce336361580fe245c4564b57bbcc4481f9137/chrome/test/BUILD.gn [modify] https://crrev.com/6a7ce336361580fe245c4564b57bbcc4481f9137/testing/buildbot/filters/BUILD.gn
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef2d1ddd17fc707765239e77a78648f9d877ff60 commit ef2d1ddd17fc707765239e77a78648f9d877ff60 Author: Evan Stade <estade@chromium.org> Date: Fri Dec 07 01:26:16 2018 Disable more single process mash unit_tests on FYI bot. Bug: 905430 Change-Id: Id99d29f22c625c33679675042ce5f7c8527f0a74 Reviewed-on: https://chromium-review.googlesource.com/c/1366715 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#614557} [modify] https://crrev.com/ef2d1ddd17fc707765239e77a78648f9d877ff60/testing/buildbot/filters/chromeos.single_process_mash.fyi.unit_tests.filter
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a8c549dd81e2932b9b103046b1121e2eaef9f30 commit 6a8c549dd81e2932b9b103046b1121e2eaef9f30 Author: Evan Stade <estade@chromium.org> Date: Mon Dec 10 20:09:37 2018 Add filter for a flaky unit test in single process mash. Bug: 905430 , 913577 Change-Id: I5625b7d5dfde7528ef0480046c27cd904804d7ed Reviewed-on: https://chromium-review.googlesource.com/c/1370386 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#615219} [modify] https://crrev.com/6a8c549dd81e2932b9b103046b1121e2eaef9f30/testing/buildbot/filters/chromeos.single_process_mash.fyi.unit_tests.filter
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed7a543d0e79b29b3514ac2ab60e75b9989f19c4 commit ed7a543d0e79b29b3514ac2ab60e75b9989f19c4 Author: Evan Stade <estade@chromium.org> Date: Thu Dec 13 00:19:13 2018 Move single process mash unit_tests from FYI to main bot. They are passing consistently (modulo the filter file). BUG= 905430 Change-Id: I2b8fe7cc40e77505eb19e15d41f304b944501f87 Reviewed-on: https://chromium-review.googlesource.com/c/1373874 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#616117} [modify] https://crrev.com/ed7a543d0e79b29b3514ac2ab60e75b9989f19c4/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/ed7a543d0e79b29b3514ac2ab60e75b9989f19c4/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/ed7a543d0e79b29b3514ac2ab60e75b9989f19c4/testing/buildbot/chromium.memory.json [modify] https://crrev.com/ed7a543d0e79b29b3514ac2ab60e75b9989f19c4/testing/buildbot/filters/BUILD.gn [rename] https://crrev.com/ed7a543d0e79b29b3514ac2ab60e75b9989f19c4/testing/buildbot/filters/chromeos.single_process_mash.unit_tests.filter [modify] https://crrev.com/ed7a543d0e79b29b3514ac2ab60e75b9989f19c4/testing/buildbot/test_suites.pyl
,
Dec 13
,
Jan 7
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by est...@chromium.org
, Nov 15Status: Started (was: Available)