Issue metadata
Sign in to add a comment
|
GLIBC breakage: 'readdir_r' is deprecated |
||||||||||||||||||||||||
Issue descriptionFirst broken release build: https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8930312117647549584 relevant warnings/errors: lxc-1.0.7: x86_64-cros-linux-gnu-clang -DHAVE_CONFIG_H -I. -I../../src -fPIC -DPIC -I../../src -DLXCROOTFSMOUNT=\"/usr/lib/lxc/rootfs\" -DLXCPATH=\"/etc/lxc\" -DLXC_GLOBAL_CONF=\"/etc/lxc/lxc.conf\" -DLXCINITDIR=\"/usr/libexec\" -DLIBEXECDIR=\"/usr/libexec\" -DLXCTEMPLATEDIR=\"/usr/share/lxc/templates\" -DLOGPATH=\"/var/log/lxc\" -DLXC_DEFAULT_CONFIG=\"/etc/lxc/default.conf\" -DLXC_USERNIC_DB=\"/run/lxc/nics\" -DLXC_USERNIC_CONF=\"/etc/lxc/lxc-usernet\" -DDEFAULT_CGROUP_PATTERN=\"/lxc/%n\" -DRUNTIME_PATH=\"/run\" -DSBINDIR=\"/usr/sbin\" -pthread -O2 -pipe -march=corei7 -g -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-strict-aliasing -Wall -Werror -c -o lsm/liblxc_so-lsm.o `test -f 'lsm/lsm.c' || echo './'`lsm/lsm.c lxc-1.0.7: [1mutils.c:62:10: [0m[0;1;31merror: [0m[1m'readdir_r' is deprecated [-Werror,-Wdeprecated-declarations][0m lxc-1.0.7: while (!readdir_r(dir, &dirent, &direntp)) { lxc-1.0.7: [0;1;32m ^ lxc-1.0.7: [0m[1m../../../../../../../../usr/include/dirent.h:186:28: [0m[0;1;30mnote: [0m'readdir_r' has been explicitly marked deprecated here[0m lxc-1.0.7: __nonnull ((1, 2, 3)) __attribute_deprecated__; lxc-1.0.7: [0;1;32m ^ lxc-1.0.7: [0m[1m../../../../../../../../usr/include/sys/cdefs.h:385:51: [0m[0;1;30mnote: [0mexpanded from macro '__attribute_deprecated__'[0m lxc-1.0.7: # define __attribute_deprecated__ __attribute__ ((__deprecated__)) lxc-1.0.7: [0;1;32m ^ lxc-1.0.7: [0m1 error generated. lxc-1.0.7: make[3]: *** [Makefile:1277: liblxc_so-utils.o] Error 1 lxc-1.0.7: make[3]: *** Waiting for unfinished jobs.... I suspect this is more fallout due to the GLIBC upgrade. I'm a bit confused by this because readdir_r was deprecated in GLIBC 2.24 per: https://sourceware.org/bugzilla/show_bug.cgi?id=19056 and I think we upgraded from GLIBC 2.25 to GLIBC 2.27, but this still seems like the most likely culprit.
,
Nov 14
,
Nov 14
arguably lxc shouldn't be building with -Werror in the first place. upstream Gentoo policy is to never do that.
,
Nov 14
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/39c8b985667ddf8facc593d245853ac486f2efcc commit 39c8b985667ddf8facc593d245853ac486f2efcc Author: Manoj Gupta <manojgupta@google.com> Date: Thu Nov 15 10:16:36 2018 guado_labstation: Fix lxc to build with glibc 2.27 Backport upstream commit to use readdir instead of readdir_r. Also include <sys/sysmacros.h> header to avoid major/minor related errors. BUG= chromium:905424 TEST=emerge-guado_labstation lxc works. Change-Id: Ideab2882a107949f94b8b8a784bc308ec489f4d1 Reviewed-on: https://chromium-review.googlesource.com/1336588 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Ross Zwisler <zwisler@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/39c8b985667ddf8facc593d245853ac486f2efcc/project-labstation/app-emulation/lxc/lxc-1.0.7-r1.ebuild [add] https://crrev.com/39c8b985667ddf8facc593d245853ac486f2efcc/project-labstation/app-emulation/lxc/files/lxc-1.0.7-readdir.patch
,
Nov 15
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by manojgupta@chromium.org
, Nov 14