PaymentRequest won't let you manually type in credit card numbers if they match server cards |
|||
Issue descriptionThis is a followup to Issue 849063 . Problem: - PaymentRequest does not show cards from Google Pay (on purpose) - PaymentRequest blocks you from manually entering any card number that matches a card on file, even if it's a server card from Google Pay - As a result, it is *impossible* to use any given card with PaymentRequest if you have that card listed with Google Pay In this scenario, we're actually creating a better user experience if users delete all their cards from Google Payments. That's definitely not what we want, because it starts creating a tradeoff of "use your cards on all your devices" vs. "be able use your cards in PaymentRequest at all". Possible solution: - Does PaymentRequest *really* need to validate against, and stop you from manually typing, a number that matches a server card? Additional info: - There's a project underway and launching soon that focuses on migrating local cards to become server cards, which will make this more and more of a problem as time goes on.
,
Nov 14
Will get back with a decision soon about this..
,
Nov 14
Since most people will have their only credit cards added to Google Pay, blocking them from W3c payment API will make that API essentially useless (typing in cc number every time is basically even less useful than not using payment api and relying on form autocomplete). Is Google committed to supporting open web standards or should PaymentRequest API be considered effectively deprecated in Chrome?
,
Nov 16
Sounds good. Started the code review process for the fix in https://crrev.com/c/1340377.
,
Nov 16
,
Nov 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e7d7df122edd4e17b24626944050756ac486107 commit 5e7d7df122edd4e17b24626944050756ac486107 Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Mon Nov 26 23:21:44 2018 [Desktop][iOS][Payment Request] Allow re-entering existing cards. Before this patch, entering an existing card into Payment Request sheet would show an error "This card is already used". This happened for both local cards, which are visible in Payment Request sheet, and for server cards, which can be accessed only in tokenized form through Google Pay. This patch allows re-entering existing cards. After this patch, entering an existing card into Payment Request sheet is allowed. This sheet may display two identical cards after the user added the card. Autofill will deduplicate two identical local cards, so the consequent autofill popups and Payment Request sheets will display the card at most once. In settings, the user will see the card twice only if one card is local (entered through Payment Request sheet) and the other card is from the server (synced down from Google Payments account). Android already behaves this way. Bug: 905396 Change-Id: I587e682855075f7035573f89dfd77711b45879ac Reviewed-on: https://chromium-review.googlesource.com/c/1340377 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#610971} [modify] https://crrev.com/5e7d7df122edd4e17b24626944050756ac486107/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc [modify] https://crrev.com/5e7d7df122edd4e17b24626944050756ac486107/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc [modify] https://crrev.com/5e7d7df122edd4e17b24626944050756ac486107/components/payments_strings.grdp [modify] https://crrev.com/5e7d7df122edd4e17b24626944050756ac486107/ios/chrome/browser/ui/payments/credit_card_edit_mediator.mm
,
Jan 17
(5 days ago)
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rouslan@google.com
, Nov 14Owner: durgapandey@chromium.org