New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 905386 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
OOO Jan 14 - 25
Cc:
Components:
EstimatedDays: ----
NextAction: 2019-01-22
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Clean up NTP feature release flags & experiments

Project Member Reported by ramyan@chromium.org, Nov 14

Issue description

In particular: ntp-ui-md, ntp-icons, ntp-custom-links & ntp-backgrounds.
 
Status: Started (was: Assigned)
NextAction: 2018-11-28
Labels: zine-triaged
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff4946ebc82d11fa515e394ea286a86254f094df

commit ff4946ebc82d11fa515e394ea286a86254f094df
Author: Ramya Nagarajan <ramyan@chromium.org>
Date: Tue Nov 27 22:41:31 2018

Enable birthday features by default.

Bug: 905386
Change-Id: I98ab459357dbb9d7043ad5fb5dd0b8084c3f7434
Reviewed-on: https://chromium-review.googlesource.com/c/1351784
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611386}
[modify] https://crrev.com/ff4946ebc82d11fa515e394ea286a86254f094df/chrome/browser/search/ntp_features.cc
[modify] https://crrev.com/ff4946ebc82d11fa515e394ea286a86254f094df/components/ntp_tiles/constants.cc

The NextAction date has arrived: 2018-11-28
Cc: kristip...@chromium.org kmilka@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0896159f33c40980e46c43ff7c56c84dcf7b4aa1

commit 0896159f33c40980e46c43ff7c56c84dcf7b4aa1
Author: Kyle Milka <kmilka@chromium.org>
Date: Thu Dec 06 19:00:38 2018

[NTP] Remove UI MD flag

Remove flag for ntp md ui. Change the new styling to be the
default and remove the md class, this mainly affects the fakebox
as the icons are styled via md-icons.

Mostly a reland of https://crrev.com/c/1265024.

Bug: 905386
Change-Id: I62db12fe3cea1e85ed615f1ad2fbb9ea211f585e
Reviewed-on: https://chromium-review.googlesource.com/c/1361720
Reviewed-by: Kristi Park <kristipark@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614432}
[modify] https://crrev.com/0896159f33c40980e46c43ff7c56c84dcf7b4aa1/chrome/browser/about_flags.cc
[modify] https://crrev.com/0896159f33c40980e46c43ff7c56c84dcf7b4aa1/chrome/browser/flag-metadata.json
[modify] https://crrev.com/0896159f33c40980e46c43ff7c56c84dcf7b4aa1/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/0896159f33c40980e46c43ff7c56c84dcf7b4aa1/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/0896159f33c40980e46c43ff7c56c84dcf7b4aa1/chrome/browser/resources/local_ntp/local_ntp.css
[modify] https://crrev.com/0896159f33c40980e46c43ff7c56c84dcf7b4aa1/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/0896159f33c40980e46c43ff7c56c84dcf7b4aa1/chrome/browser/search/local_ntp_source.cc
[modify] https://crrev.com/0896159f33c40980e46c43ff7c56c84dcf7b4aa1/chrome/browser/search/ntp_features.cc
[modify] https://crrev.com/0896159f33c40980e46c43ff7c56c84dcf7b4aa1/chrome/browser/search/ntp_features.h
[modify] https://crrev.com/0896159f33c40980e46c43ff7c56c84dcf7b4aa1/chrome/browser/ui/search/local_ntp_browsertest.cc
[modify] https://crrev.com/0896159f33c40980e46c43ff7c56c84dcf7b4aa1/chrome/test/data/local_ntp/local_ntp_browsertest.js
[modify] https://crrev.com/0896159f33c40980e46c43ff7c56c84dcf7b4aa1/testing/variations/fieldtrial_testing_config.json

NextAction: 2019-01-08
The NextAction date has arrived: 2019-01-08
NextAction: 2019-01-22
Remote changes in progress.
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/285005f14d06fa764fb2475c30de4d6adbd03336

commit 285005f14d06fa764fb2475c30de4d6adbd03336
Author: Kyle Milka <kmilka@chromium.org>
Date: Wed Jan 09 02:38:07 2019

[NTP] Remove custom backgrounds flag

Remove ntp custom backgrounds flag and all references to it.

Bug: 905386
Change-Id: Ic7e782e113eadc7e2f40a06edd48eb625f98602c
Reviewed-on: https://chromium-review.googlesource.com/c/1256242
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621010}
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/about_flags.cc
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/flag-metadata.json
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/resources/local_ntp/custom_backgrounds.js
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/search/background/ntp_background_service.cc
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/search/background/ntp_background_service.h
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/search/background/ntp_background_service_factory.cc
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/search/background/ntp_background_service_unittest.cc
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/search/instant_service.cc
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/search/instant_service_unittest.cc
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/search/local_ntp_source.cc
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/search/ntp_features.cc
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/search/ntp_features.h
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/ui/search/local_ntp_backgrounds_browsertest.cc
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/ui/search/ntp_user_data_logger.cc
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/browser/ui/search/ntp_user_data_logger_unittest.cc
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/chrome/test/data/local_ntp/custom_backgrounds_browsertest.js
[modify] https://crrev.com/285005f14d06fa764fb2475c30de4d6adbd03336/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f75cbf4973b50033f95e86d495e0b50fd22bd9cd

commit f75cbf4973b50033f95e86d495e0b50fd22bd9cd
Author: Kristi Park <kristipark@chromium.org>
Date: Wed Jan 09 22:14:03 2019

[NTP] Remove NTP Icons flag

Remove the ntp-icons flag and make Material Design styling default for
the Most Visited section. The ".md-icons" class will remain for
third-party NTP support. Material design for the individual tiles has
already been made default in https://crrev.com/c/1313868.

Bug: 905386
Change-Id: I87a232df1f4943f08a849cc252035a75d900bdab
Reviewed-on: https://chromium-review.googlesource.com/c/1381252
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621322}
[modify] https://crrev.com/f75cbf4973b50033f95e86d495e0b50fd22bd9cd/chrome/browser/about_flags.cc
[modify] https://crrev.com/f75cbf4973b50033f95e86d495e0b50fd22bd9cd/chrome/browser/flag-metadata.json
[modify] https://crrev.com/f75cbf4973b50033f95e86d495e0b50fd22bd9cd/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/f75cbf4973b50033f95e86d495e0b50fd22bd9cd/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/f75cbf4973b50033f95e86d495e0b50fd22bd9cd/chrome/browser/history/top_sites_factory.cc
[modify] https://crrev.com/f75cbf4973b50033f95e86d495e0b50fd22bd9cd/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/f75cbf4973b50033f95e86d495e0b50fd22bd9cd/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/f75cbf4973b50033f95e86d495e0b50fd22bd9cd/chrome/browser/search/local_ntp_source.cc
[modify] https://crrev.com/f75cbf4973b50033f95e86d495e0b50fd22bd9cd/chrome/browser/search/ntp_features.cc
[modify] https://crrev.com/f75cbf4973b50033f95e86d495e0b50fd22bd9cd/chrome/browser/search/ntp_features.h
[modify] https://crrev.com/f75cbf4973b50033f95e86d495e0b50fd22bd9cd/chrome/browser/ui/search/local_ntp_browsertest.cc
[modify] https://crrev.com/f75cbf4973b50033f95e86d495e0b50fd22bd9cd/components/ntp_tiles/constants.h
[modify] https://crrev.com/f75cbf4973b50033f95e86d495e0b50fd22bd9cd/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41653081fae042a9a7395263c48e566a119efc2b

commit 41653081fae042a9a7395263c48e566a119efc2b
Author: Kristi Park <kristipark@chromium.org>
Date: Wed Jan 09 22:20:30 2019

[NTP] Remove custom links flag

Remove the ntp-custom-links flag and make the custom links feature on by
default.

Bug: 905386
Change-Id: I71f6d85c8d911ad6ad78b4e188854319f42a55a0
Reviewed-on: https://chromium-review.googlesource.com/c/1381551
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621333}
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/chrome/browser/about_flags.cc
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/chrome/browser/flag-metadata.json
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/chrome/browser/ntp_tiles/chrome_custom_links_manager_factory.cc
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/chrome/browser/resources/local_ntp/custom_backgrounds.js
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/chrome/browser/search/instant_service.cc
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/chrome/browser/search/instant_service_unittest.cc
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/chrome/browser/search/local_ntp_source.cc
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/chrome/browser/search/ntp_features.cc
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/chrome/browser/search/ntp_features.h
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/chrome/browser/ui/search/local_ntp_browsertest.cc
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/chrome/browser/ui/search/local_ntp_render_browsertest.cc
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/chrome/browser/ui/search/ntp_user_data_logger.cc
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/chrome/renderer/searchbox/searchbox_extension.cc
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/components/ntp_tiles/constants.cc
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/components/ntp_tiles/constants.h
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/components/ntp_tiles/most_visited_sites.cc
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/components/ntp_tiles/most_visited_sites_unittest.cc
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc
[modify] https://crrev.com/41653081fae042a9a7395263c48e566a119efc2b/testing/variations/fieldtrial_testing_config.json

Comment 14 by monor...@bugs.chromium.org, Today (19 hours ago)

The NextAction date has arrived: 2019-01-22

Sign in to add a comment