Uniformly link to stainless logs from builders |
|||||
Issue descriptionSheriffs / developers were finding the logs link named "stainless results" confusing on the skylab task landing page. Name it better -- "stainless logs"? "test logs"? "autotest logs"?
,
Nov 14
My vote is for "test logs" (especially since this includes logs from Tast, and not just ones from Autotest). :-P Much of my confusion was also due to the link being small and tucked away near the bottom of the page. The page that I was looking at, https://chromeos-swarming.appspot.com/task?id=412b0bee1c808a10&refresh=10#, is very, very busy, and it was hard to know where to look. In fact, when I load it now, I don't even see the results link that I clicked before. There's a huge gray frame with "Requests to the server have been blocked by an extension." If the SkylabHWTest stages at http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8929889316962419728 just linked to the Stainless GCS viewer instead of to these chromeos-swarming.appspot.com, that'd be plenty good for me. Minimizing the number of clicks from a failed build to the test/DUT logs is important.
,
Nov 15
I looked at how derat@ was getting to logs, and I'll change the ask here. On the builder page, let's *always* link to the *stainless logs* for a test with the name "test logs". Currently, these are only shown on the builder page if - it's an autotest test - the test failed. Let's make this uniform across suite vs test; pass vs fail; autotest vs skylab.
,
Nov 15
,
Nov 15
+1 to "test logs". I'm even afraid it was a bit confusing to put log viewer on stainless; maybe we could have another host.
,
Dec 17
What's the status here? The SkyLab pages are still confusing tree guardians; see e.g. issue 915841 .
,
Dec 18
Have a CL to rename to "Task logs (Stainless)" https://chromium-review.googlesource.com/c/infra/infra/+/1382575
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/8b4f14fabaf959b2cce3a6d45989dba49849bc00 commit 8b4f14fabaf959b2cce3a6d45989dba49849bc00 Author: Allen Li <ayatane@chromium.org> Date: Tue Dec 18 23:05:06 2018 skylab_swarming_worker: Improve messages Address some user concerns:: Skipping... message could be confusing and doesn't otherwise provide much value. Finalization is a little wordy. Epilog is slightly better. Some users were confused that Stainless results meant task results, clarified for people who don't know about Stainless. R=akeshet@chromium.org Bug: 905360 Change-Id: I5e6257ac7fb46c6fc1211cb584655e4324e57d91 Reviewed-on: https://chromium-review.googlesource.com/c/1382575 Reviewed-by: Aviv Keshet <akeshet@chromium.org> Commit-Queue: Allen Li <ayatane@chromium.org> Cr-Commit-Position: refs/heads/master@{#19648} [modify] https://crrev.com/8b4f14fabaf959b2cce3a6d45989dba49849bc00/go/src/infra/cmd/skylab_swarming_worker/lucifer_posix.go
,
Dec 20
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ayatane@chromium.org
, Nov 14