New issue
Advanced search Search tips

Issue 905360 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Uniformly link to stainless logs from builders

Project Member Reported by pprabhu@chromium.org, Nov 14

Issue description

Sheriffs / developers were finding the logs link named "stainless results" confusing on the skylab task landing page.

Name it better -- "stainless logs"? "test logs"? "autotest logs"?

 
Could you CC some of these Sheriffs, developers with some opinions on what would be a better name?
Cc: akes...@chromium.org jclinton@chromium.org nya@chromium.org ihf@chromium.org hidehiko@chromium.org
My vote is for "test logs" (especially since this includes logs from Tast, and not just ones from Autotest). :-P

Much of my confusion was also due to the link being small and tucked away near the bottom of the page. The page that I was looking at, https://chromeos-swarming.appspot.com/task?id=412b0bee1c808a10&refresh=10#, is very, very busy, and it was hard to know where to look.

In fact, when I load it now, I don't even see the results link that I clicked before. There's a huge gray frame with "Requests to the server have been blocked by an extension."

If the SkylabHWTest stages at http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8929889316962419728 just linked to the Stainless GCS viewer instead of to these chromeos-swarming.appspot.com, that'd be plenty good for me.

Minimizing the number of clicks from a failed build to the test/DUT logs is important.
Owner: pprabhu@chromium.org
I looked at how derat@ was getting to logs, and I'll change the ask here.

On the builder page, let's *always* link to the *stainless logs* for a test with the name "test logs".

Currently, these are only shown on the builder page if
- it's an autotest test
- the test failed.

Let's make this uniform across suite vs test; pass vs fail; autotest vs skylab.
Summary: Uniformly link to stainless logs from builders (was: Rename stainless logs link on test page)
+1 to "test logs". I'm even afraid it was a bit confusing to put log viewer on stainless; maybe we could have another host.

What's the status here? The SkyLab pages are still confusing tree guardians; see e.g.  issue 915841 .
Have a CL to rename to "Task logs (Stainless)"

https://chromium-review.googlesource.com/c/infra/infra/+/1382575
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8b4f14fabaf959b2cce3a6d45989dba49849bc00

commit 8b4f14fabaf959b2cce3a6d45989dba49849bc00
Author: Allen Li <ayatane@chromium.org>
Date: Tue Dec 18 23:05:06 2018

skylab_swarming_worker: Improve messages

Address some user concerns::

Skipping... message could be confusing and doesn't otherwise
provide much value.

Finalization is a little wordy.  Epilog is slightly better.

Some users were confused that Stainless results meant task results,
clarified for people who don't know about Stainless.

R=akeshet@chromium.org

Bug: 905360
Change-Id: I5e6257ac7fb46c6fc1211cb584655e4324e57d91
Reviewed-on: https://chromium-review.googlesource.com/c/1382575
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19648}
[modify] https://crrev.com/8b4f14fabaf959b2cce3a6d45989dba49849bc00/go/src/infra/cmd/skylab_swarming_worker/lucifer_posix.go

Components: -Infra>Client>ChromeOS>Test Infra>Client>ChromeOS>Test>Platform

Sign in to add a comment