New issue
Advanced search Search tips

Issue 905353 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

autotest backchannel.py fails to identify some Ethernet adapter

Project Member Reported by benchan@chromium.org, Nov 14

Issue description

The backchannel.py script in autotest currently uses the 'Port' property reported by ethtool to decide if a network interface is an adapter. However, that doesn't work for some Ethernet adapters as we've observed in the test lab.

One example is the Linksys Linksys USB3GIG USB 3.0 Gigabit Ethernet Adapter (USB 13b1:0041), which has not much information in the ethtool report to determine if it's an Ethernet adapter:

  Settings for eth0:
        Current message level: 0x00000007 (7)
                               drv probe link
        Link detected: yes

This issue leads to some test failures like:

INIT_ERROR: An ethernet connection is required between the test server and the device under test.

 
Status: Started (was: Untriaged)
Components: OS>Systems>Mobile
I think Ben is looking to work around this:

https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1334498
Cc: englab-sys-cros@google.com
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/032d0e18dc1cc7a686ca8ea9f227738b148bb9b2

commit 032d0e18dc1cc7a686ca8ea9f227738b148bb9b2
Author: Ben Chan <benchan@chromium.org>
Date: Fri Nov 16 13:02:18 2018

autotest: backchannel: handle Ethernet adapters with unknown port type

backchannel.py currently uses the port type reported by ethtool to
determine if a network interface is Ethernet. However, ethtool fails to
report the port type for some Ethernet adapters. This CL adds a fallback
to check against a list of known Ethernet adapters based on their
VID/PID.

BUG= chromium:905353 
TEST=Run pseudomodem tests on a DUT with Linksys USB3GIG Ethernet adapter.

Change-Id: I31ca12c91bea27653f8b04d28c4b546fa3ad43ff
Reviewed-on: https://chromium-review.googlesource.com/1334498
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/032d0e18dc1cc7a686ca8ea9f227738b148bb9b2/client/cros/backchannel.py

Status: Fixed (was: Started)
Should be fixed? No new results yet, so feel free to reopen if this issue pops back up.

Sign in to add a comment