chromeos-firmware-scarlet build failed: Cannot pack firmware updater. |
||
Issue descriptionFailed build: https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8929898556145804720 Relevant log: https://luci-logdog.appspot.com/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8929898556145804720/+/steps/BuildPackages/0/stdout Here's the failure message: chromeos-firmware-scarlet-0.0.1-r138: Packed output image is: /build/scarlet/tmp/portage/chromeos-base/chromeos-firmware-scarlet-0.0.1-r138/work/chromeos-firmware-scarlet-0.0.1/chromeos-firmwareupdate chromeos-firmware-scarlet-0.0.1-r138: * Build scarlet local firmware updater to updater.sh: -b /build/scarlet/firmware/image-BUILD_TARGET.bin --root /build/scarlet -i /build/scarlet/tmp/portage/chromeos-base/chromeos-firmware-scarlet-0.0.1-r138/distdir -c /build/scarlet//usr/share/chromeos-config/yaml/config.yaml --local chromeos-firmware-scarlet-0.0.1-r138: Traceback (most recent call last): chromeos-firmware-scarlet-0.0.1-r138: File "./pack_firmware.py", line 1140, in <module> chromeos-firmware-scarlet-0.0.1-r138: main(sys.argv) chromeos-firmware-scarlet-0.0.1-r138: File "./pack_firmware.py", line 1137, in main chromeos-firmware-scarlet-0.0.1-r138: packer.Start(argv[1:]) chromeos-firmware-scarlet-0.0.1-r138: File "./pack_firmware.py", line 1121, in Start chromeos-firmware-scarlet-0.0.1-r138: self._WriteSignerInstructions(model_details) chromeos-firmware-scarlet-0.0.1-r138: File "./pack_firmware.py", line 1053, in _WriteSignerInstructions chromeos-firmware-scarlet-0.0.1-r138: ec_fname = self._EcImageOutput(image_files[EC].firmware_ids, dirname) chromeos-firmware-scarlet-0.0.1-r138: KeyError: 'EC' chromeos-firmware-scarlet-0.0.1-r138: * ERROR: chromeos-base/chromeos-firmware-scarlet-0.0.1-r138::scarlet-private failed (compile phase): chromeos-firmware-scarlet-0.0.1-r138: * Cannot pack firmware updater. There was one CL that removed a default param and specifically mentioned that pack_firmware.py provided it's own default value. I've asked the CL author to check to see if that could have caused this failure. https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1326301
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/d3c5f00833bc485215e899a9a87ad66649379972 commit d3c5f00833bc485215e899a9a87ad66649379972 Author: Hung-Te Lin <hungte@chromium.org> Date: Fri Nov 16 07:54:33 2018 pack_firmware: Fix local builder when EC image was not specified For boards (for instance, scarlet) defined bootimage and not cros_ec, the cros-firmware eclass will only specify "--local -b" and no "-e", causing image_files to not have 'EC' as key. Since EC images are optional, we should check before getting its file values. BUG=b:119290803, chromium:905318 TEST=emerge-scarlet chromeos-firmware-scarlet Change-Id: I44b86f3a4e214af6cf0aafe3dbc1f3d72e83c756 Reviewed-on: https://chromium-review.googlesource.com/1335967 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Evan Hernandez <evanhernandez@chromium.org> [modify] https://crrev.com/d3c5f00833bc485215e899a9a87ad66649379972/pack_firmware.py
,
Nov 17
|
||
►
Sign in to add a comment |
||
Comment 1 by hungte@chromium.org
, Nov 15Status: Started (was: Untriaged)