Public session login shows too scary warning about admin monitoring your activity |
|||||||||
Issue descriptionChrome Version: 71 What steps will reproduce the problem? (1) Configure public session and auto-login for a managed device. (2) Try to login into a public session. What is the expected result? A soft warning about your session being a public session. What happens instead? A scary warning about admin monitoring all your activity which is intended to be used for "Managed guest sessions".
,
Nov 14
merge for M71 requested
,
Nov 15
,
Nov 15
,
Nov 15
Approving merge to M71 Chrome OS.
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f644fe3236b65e091553a0ccfcd34e140e37bcc9 commit f644fe3236b65e091553a0ccfcd34e140e37bcc9 Author: Zakhar Voit <voit@google.com> Date: Fri Nov 16 12:36:40 2018 [Merge M71] Remove red warning icon from public session login page This is a temporary change until we support managed sessions properly and can show the UI based on whether we run public session or managed session. Bug: 905317 Change-Id: I03c15f2d0bc59ed9a86d4da86aa62590721366eb Reviewed-on: https://chromium-review.googlesource.com/c/1335584 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Ivan Šandrk <isandrk@chromium.org> Commit-Queue: Zakhar Voit <voit@google.com> Cr-Original-Commit-Position: refs/heads/master@{#608088}(cherry picked from commit 7488f36809d7a737ae81934b8bf16985243725e6) Reviewed-on: https://chromium-review.googlesource.com/c/1339539 Cr-Commit-Position: refs/branch-heads/3578@{#729} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/f644fe3236b65e091553a0ccfcd34e140e37bcc9/ash/login/ui/login_expanded_public_account_view.cc
,
Nov 16
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision f644fe3236b65e091553a0ccfcd34e140e37bcc9 was merged to refs/branch-heads/3578 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f644fe3236b65e091553a0ccfcd34e140e37bcc9 Commit: f644fe3236b65e091553a0ccfcd34e140e37bcc9 Author: voit@google.com Commiter: isandrk@chromium.org Date: 2018-11-16 12:36:40 +0000 UTC [Merge M71] Remove red warning icon from public session login page This is a temporary change until we support managed sessions properly and can show the UI based on whether we run public session or managed session. Bug: 905317 Change-Id: I03c15f2d0bc59ed9a86d4da86aa62590721366eb Reviewed-on: https://chromium-review.googlesource.com/c/1335584 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Ivan Šandrk <isandrk@chromium.org> Commit-Queue: Zakhar Voit <voit@google.com> Cr-Original-Commit-Position: refs/heads/master@{#608088}(cherry picked from commit 7488f36809d7a737ae81934b8bf16985243725e6) Reviewed-on: https://chromium-review.googlesource.com/c/1339539 Cr-Commit-Position: refs/branch-heads/3578@{#729} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 19
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 19
Kevin had a typo when approving the merge. Should have been: "-Merge-Request-71 Merge-Approved-71 M-71" But was: "-Merge-Request-71 Merge-Approved-70 M-71" |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 14