New issue
Advanced search Search tips

Issue 905316 link

Starred by 1 user
Status: Fixed
Owner:
rmis...@google.com
Closed: Nov 26
Cc:
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"TypeError: Cannot read property 'length' of undefined" error popup from chromium-behavior plugin in WIP mode

Project Member Reported by rmis...@google.com, Nov 14 

Console says:
gr-app.js:1562 TypeError: Cannot read property 'length' of undefined
    at chromium-behavior.html:419

It corresponds to a line in the Auto-Submit feature in chromium-behavior.html plugin added in  Issue 631551 .
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior/+/f54f4638f236e65eae86f0360c61eb39195fafb4

commit f54f4638f236e65eae86f0360c61eb39195fafb4
Author: Ravi Mistry <rmistry@google.com>
Date: Wed Nov 14 15:37:10 2018

Check to see if change.labels[REVIEW_LABEL].all exists

Does not look like the labels have that array when the change is in WIP mode.

Bug:  905316 
Change-Id: Ifb4695e040f1c9acc8e93eddff646448512dc35a
[modify] https://crrev.com/f54f4638f236e65eae86f0360c61eb39195fafb4/src/main/resources/static/chromium-behavior.html

Comment 2 by rmis...@google.com, Nov 15 

Did the copybara change in cl/221634253.
Now waiting for it to be pushed to production.

Comment 3 by rmis...@google.com, Nov 26

Status: Fixed (was: Started)
Fix is now in production. Marking as fixed.
►

Sign in to add a comment