New issue
Advanced search Search tips

Issue 905314 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 29
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Float-cast-overflow in blink::BaseRenderingContext2D::drawImage

Project Member Reported by ClusterFuzz, Nov 14

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6109113349832704

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  blink::BaseRenderingContext2D::drawImage
  drawImage3Method
  drawImageMethod
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=605725:605733

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6109113349832704

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 14

Components: Blink>Canvas
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 14

Labels: Test-Predator-Auto-Owner
Owner: davidqu@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/aff00809f48803f0e5ac50bfc1dee0817d1e3d70 (Add Canvas.DrawImage by size histogram).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df19cc67459ae314f949ac1c83cb4cc24c0a6802

commit df19cc67459ae314f949ac1c83cb4cc24c0a6802
Author: David Quiroz Marin <davidqu@chromium.org>
Date: Wed Nov 28 22:56:18 2018

Fix float-cast-overflow in square root of pixels calculations.

Some of the canvas UMA histograms use the square root of total
pixels in an image or canvas in this CL uses CheckedNumeric to
avoid overflow.

Bug:  905314 
Change-Id: I10a85c5c372406449a64f1e32153d58d560e901c
Reviewed-on: https://chromium-review.googlesource.com/c/1351519
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611916}
[modify] https://crrev.com/df19cc67459ae314f949ac1c83cb4cc24c0a6802/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.cc
[modify] https://crrev.com/df19cc67459ae314f949ac1c83cb4cc24c0a6802/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/df19cc67459ae314f949ac1c83cb4cc24c0a6802/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
[modify] https://crrev.com/df19cc67459ae314f949ac1c83cb4cc24c0a6802/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.h

Project Member

Comment 4 by ClusterFuzz, Nov 29

ClusterFuzz has detected this issue as fixed in range 611915:611916.

Detailed report: https://clusterfuzz.com/testcase?key=6109113349832704

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  blink::BaseRenderingContext2D::drawImage
  drawImage3Method
  drawImageMethod
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=605725:605733
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=611915:611916

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6109113349832704

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Nov 29

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6109113349832704 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment