Existing infobars don't schedule a repaint when theme color changes
Reported by
khushal....@etouch.net,
Nov 14
|
|||||
Issue descriptionChrome Version: 71.0.3578.53 (Official Build) Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669} (32/64-bit) OS: Windows (7, 8, 8.1, 10) Test URL: https://www.google.com/ Theme URL: https://chrome.google.com/webstore/detail/material-incognito-dark-t/ahifcnpnjgbadkjdhagpfjfkmlapfoel?utm_source=chrome-ntp-icon What steps will reproduce the problem? (1) Launch chrome, navigate to above test URL and click on 'View site information' chip present in omnibox ('connection is secure' bubble will appear). (2) Click on 'Site settings' option and change any setting to 'Allow' or 'Block' state from dropdown list such that 'Reload' infobar appears on 'Google' webpage. (3) Apply theme from above theme URL and immediately switch to 'Google' tab that is opened such that 'Undo' infobar appears on 'Google' webpage. (4) Observe the Infobar. Actual Result: White patch is seen over 'Site settings' infobar when any theme is applied in chrome. Expected Result: 'Site settings' infobar should be seen properly without any patch when any theme is applied in chrome. This is a Regression issue seen from 'M-67' and providing the bisect info below: Good Build: 67.0.3382.0 (Revision: 546347) Bad Build: 67.0.3383.0 (Revision: 546671) You are probably looking for a change made after 546652 (known good), but no later than 546653 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/addcd1672c2379778d155baa4b7d49ef65150d2d..cfb3ca21bc9f62f0c6723eba8a726ba9decb4653 Suspect: https://chromium.googlesource.com/chromium/src/+/cfb3ca21bc9f62f0c6723eba8a726ba9decb4653 @pkasting: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: 1. Issue is also seen on M-70 Stable (build #70.0.3538.102), M-72 Dev (build #72.0.3608.4) and M-72 Canary (build #72.0.3610.0). 2. Issue is not seen on Mac (10.13.1, 10.13.6, 10.14.2) OS. Kindly refer the attached screen-cast. Thank You..!!
,
Nov 22
,
Nov 29
,
Dec 11
,
Dec 13
Probably the infobar code just needs to repaint explicitly on theme change. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by robliao@chromium.org
, Nov 17