The custom suppressor behavior in AEC3 during stationary render noise causes echo leakage |
||||||
Issue descriptionThe custom suppressor behavior that is used in AEC3 for increasing the transparency during periods of a render signal that is stationary have been shown to cause echo leakage.
,
Nov 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ca8119405e2a1be6394bae1b3fa85af99813808 commit 3ca8119405e2a1be6394bae1b3fa85af99813808 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Nov 14 23:34:24 2018 Roll src/third_party/webrtc 24643488d40a..83aa5ace99a5 (4 commits) https://webrtc.googlesource.com/src.git/+log/24643488d40a..83aa5ace99a5 git log 24643488d40a..83aa5ace99a5 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 jacadd@microsoft.com Adding Microsoft Corporation (*@microsoft.com) to WebRTC AUTHORS 2018-11-14 amithi@webrtc.org Prevent channels being set on stopped transceiver. 2018-11-14 peah@webrtc.org AEC3: Turn off the specific suppressor mode for stationary render 2018-11-14 shampson@webrtc.org Adding shampson to media/OWNERS. Created with: gclient setdep -r src/third_party/webrtc@83aa5ace99a5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:905291,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia5ba53138b969632f081a87c82a5ffc63599ed0c Reviewed-on: https://chromium-review.googlesource.com/c/1336219 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608169} [modify] https://crrev.com/3ca8119405e2a1be6394bae1b3fa85af99813808/DEPS
,
Nov 15
We would like to merge this to M71. It addresses an issue introduced in M71 that was discovered during Beta testing. The merge is to be considered very safe: -The fixing CL has been tested in Canary and as well as offline -It reverts the behavior to the well-tested behavior on M70. -Two kill-switches were added that can deactivate the effect of the CL -The code is only active beneath a finch experiment. The CL we would like to merge is -https://webrtc-review.googlesource.com/c/src/+/110902
,
Nov 15
This bug requires manual review: Less than 15 days to go before AppStore submit on M71 Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 15
Approving merge to M71 branch 3578 based on comment #3. Please merge ASAP. Thank you.
,
Nov 15
The merge is done. The merging CL is -https://webrtc-review.googlesource.com/c/src/+/111066
,
Nov 15
,
Nov 16
Remvoving "Merge-Approved-71" label per comment #6. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Nov 14