New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 905291 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

The custom suppressor behavior in AEC3 during stationary render noise causes echo leakage

Project Member Reported by peah@chromium.org, Nov 14

Issue description

The custom suppressor behavior that is used in AEC3 for increasing the transparency during periods of a render signal that is stationary have been shown to cause echo leakage.
 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/1724a80e2d03289ff312c2db19b6c5f47e706765

commit 1724a80e2d03289ff312c2db19b6c5f47e706765
Author: Per Åhgren <peah@webrtc.org>
Date: Wed Nov 14 15:45:47 2018

AEC3: Turn off the specific suppressor mode for stationary render

Bug:  webrtc:9998 , chromium:905291 
Change-Id: I0e9f029227349dcde280895d905e90cc90f3e072
Reviewed-on: https://webrtc-review.googlesource.com/c/110902
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25640}
[modify] https://crrev.com/1724a80e2d03289ff312c2db19b6c5f47e706765/api/audio/echo_canceller3_config.h
[modify] https://crrev.com/1724a80e2d03289ff312c2db19b6c5f47e706765/modules/audio_processing/aec3/echo_canceller3.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ca8119405e2a1be6394bae1b3fa85af99813808

commit 3ca8119405e2a1be6394bae1b3fa85af99813808
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Nov 14 23:34:24 2018

Roll src/third_party/webrtc 24643488d40a..83aa5ace99a5 (4 commits)

https://webrtc.googlesource.com/src.git/+log/24643488d40a..83aa5ace99a5


git log 24643488d40a..83aa5ace99a5 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 jacadd@microsoft.com Adding Microsoft Corporation (*@microsoft.com) to WebRTC AUTHORS
2018-11-14 amithi@webrtc.org Prevent channels being set on stopped transceiver.
2018-11-14 peah@webrtc.org AEC3: Turn off the specific suppressor mode for stationary render
2018-11-14 shampson@webrtc.org Adding shampson to media/OWNERS.


Created with:
  gclient setdep -r src/third_party/webrtc@83aa5ace99a5

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:905291,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ia5ba53138b969632f081a87c82a5ffc63599ed0c
Reviewed-on: https://chromium-review.googlesource.com/c/1336219
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608169}
[modify] https://crrev.com/3ca8119405e2a1be6394bae1b3fa85af99813808/DEPS

Cc: gustaf@chromium.org huib@chromium.org hlundin@chromium.org
Labels: Merge-Request-71
We would like to merge this to M71. It addresses an issue introduced in M71 that was discovered during Beta testing.

The merge is to be considered very safe:
-The fixing CL has been tested in Canary and as well as offline
-It reverts the behavior to the well-tested behavior on M70. 
-Two kill-switches were added that can deactivate the effect of the CL
-The code is only active beneath a finch experiment.

The CL we would like to merge is
-https://webrtc-review.googlesource.com/c/src/+/110902
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 15

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: Less than 15 days to go before AppStore submit on M71
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Approved-71
Approving merge to M71 branch 3578 based on comment #3. Please merge ASAP. Thank you.
The merge is done. The merging CL is
-https://webrtc-review.googlesource.com/c/src/+/111066
Labels: Merge-Merged M-71
Status: Fixed (was: Assigned)
Labels: -Merge-Merged -Merge-Approved-71 Merge-Merge-71
Remvoving "Merge-Approved-71" label per comment #6.

Sign in to add a comment