New issue
Advanced search Search tips

Issue 905282 link

Starred by 3 users
Status: Started
Owner:
je_julie.kim@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 907901
issue 922019
Blocking:
issue 883318



Sign in to add a comment

Convert OAuth2LoginManager away from ProfileOAuth2TokenService

Project Member Reported by blundell@chromium.org, Nov 14 
Mostly uses APIs that will be available in RefreshTokenStateMutator, so best to wait on this conversion until the blocking bug is fixed. At that point it looks like it should be straightforward.

Comment 1 by blundell@chromium.org, Dec 13

Blockedon: -887870 907901

Comment 2 by je_julie.kim@chromium.org, Jan 15

Owner: je_julie.kim@chromium.org
Status: Started (was: Available)

Comment 3 by je_julie.kim@chromium.org, Jan 16

Blockedon: 922019

Comment 4 by je_julie.kim@chromium.org, Jan 18 (5 days ago)

Blockedon: -922019
PO2TS::LoadCredentials from OAuth2LoginManager was removed at https://chromium-review.googlesource.com/c/1412831.
So, I remove  crbug.com/922019  from 'Blocked on' field.

Comment 5 by blundell@chromium.org, Jan 18 (4 days ago) 

Hi, 

Thanks for looking at this!

We actually leave the blocking relationships in-place in general for historical accuracy; when a blocking bug is fixed the UI puts a strikethrough on it so you can easily visually see whether there are any outstanding blocking bugs. Do you mind restoring the blocking relationships in this and any other cases? I appreciate it, thank you!

Comment 6 by je_julie.kim@chromium.org, Jan 18 (4 days ago)

Blockedon: 922019
Hi, Colin,
Sorry for  Sorry for the confusion.
I restored it. Thanks.
►

Sign in to add a comment