New issue
Advanced search Search tips

Issue 905280 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 16
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318



Sign in to add a comment

Convert oauth2_browsertest.cc away from ProfileOAuth2TokenService

Project Member Reported by blundell@chromium.org, Nov 14

Issue description

It looks like the conversion to IdentityManager should be completely straightforward.
 
Blocking: 883318
Owner: ma...@igalia.com
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5560ed3ac404325da1ad3b2272469b6236bb85ca

commit 5560ed3ac404325da1ad3b2272469b6236bb85ca
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Fri Nov 16 17:12:21 2018

Convert oauth2_browsertest.cc away from ProfileOAuth2TokenService

Replace usage of PO2TS APIs with calls to IdentityManager's methods.

Bug:  905280 
Change-Id: I5ea837b30e2ca44ca3e44ef012d81aff57acc636
Reviewed-on: https://chromium-review.googlesource.com/c/1338105
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#608816}
[modify] https://crrev.com/5560ed3ac404325da1ad3b2272469b6236bb85ca/chrome/browser/chromeos/login/signin/oauth2_browsertest.cc
[modify] https://crrev.com/5560ed3ac404325da1ad3b2272469b6236bb85ca/chrome/test/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment