New issue
Advanced search Search tips

Issue 905279 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 16
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318
issue 883330



Sign in to add a comment

Convert ArcAndroidManagementChecker to IdentityManager

Project Member Reported by blundell@chromium.org, Nov 14

Issue description

Its usage of PO2TS and SigninManager is straightforward.
 
Blocking: 883330 883318
Owner: toniki...@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86ecac871adc571baa6afa8bc4f26bdb7dd86dd0

commit 86ecac871adc571baa6afa8bc4f26bdb7dd86dd0
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri Nov 16 00:36:47 2018

[s13n] Convert ArcAndroidManagementChecker to IdentityManager

IdentityManager API provides a replacement to objects including SigninManager
and PO2TS. Since its implementation wraps both objects,
no functionality change is expected.

Note: This CL can not eliminate the uses of PO2TS completely from
ArcAndroidManagementChecker because it is still needed for creating
another object, AndroidManagementClient. This object will be
migrated on its own CL.

BUG= 905279 

Change-Id: I57096d6ff829afdfb3f4d882e390b87e9391ab12
Reviewed-on: https://chromium-review.googlesource.com/c/1335908
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608600}
[modify] https://crrev.com/86ecac871adc571baa6afa8bc4f26bdb7dd86dd0/chrome/browser/chromeos/arc/policy/arc_android_management_checker.cc
[modify] https://crrev.com/86ecac871adc571baa6afa8bc4f26bdb7dd86dd0/chrome/browser/chromeos/arc/policy/arc_android_management_checker.h

Status: Fixed (was: Started)

Sign in to add a comment