New issue
Advanced search Search tips

Issue 905278 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 3
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: ExtensionsActivityLogTest.TestActivityLogVisible



Sign in to add a comment

ExtensionsActivityLogTest.TestActivityLogVisible is flaky

Project Member Reported by Findit, Nov 14

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7662f4b0a581380e266a3f709a7f9442f6e7138a

commit 7662f4b0a581380e266a3f709a7f9442f6e7138a
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Wed Nov 14 13:04:49 2018

Revert "[Extensions] Add recent extension activities to the activity log page"

This reverts commit e393ff4753bfe97f90e9614feda10a0ca1d73f08.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 607924 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZTM5M2ZmNDc1M2JmZTk3ZjkwZTk2MTRmZWRhMTBhMGNhMWQ3M2YwOAw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/4885

Sample Failed Step: browser_tests on Ubuntu-16.04

Sample Flaky Test: ExtensionsActivityLogTest.TestActivityLogVisible

Original change's description:
> [Extensions] Add recent extension activities to the activity log page
> 
> Show recent extension activities by making a call to
> chrome.activityLogPrivate.getExtensionActivities whenever the user
> navigates to the activity log page. Currently, the activity type,
> api call, event count and page url (if there is one) are shown
> in descending order of event count.
> 
> Note: the activity log database can sometimes store more than one entry
> that has the same api call/event type. This CL currently does not
> group any duplicate activity entries.
> 
> Bug: 832354
> Change-Id: I0191d77cd7961bdc5d95ec8daea98d39b1a7c638
> Reviewed-on: https://chromium-review.googlesource.com/c/1321166
> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607924}

Change-Id: I0074574f067f532e3398b48254a52bb9f7a7af0f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 832354,  905278 
Reviewed-on: https://chromium-review.googlesource.com/c/1335827
Cr-Commit-Position: refs/heads/master@{#607964}
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/chrome/app/md_extensions_strings.grdp
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/chrome/browser/resources/md_extensions/BUILD.gn
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/chrome/browser/resources/md_extensions/activity_log.html
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/chrome/browser/resources/md_extensions/activity_log.js
[delete] https://crrev.com/eab6e04f58c9f5182a76e00260559f010fc15bec/chrome/browser/resources/md_extensions/activity_log_item.html
[delete] https://crrev.com/eab6e04f58c9f5182a76e00260559f010fc15bec/chrome/browser/resources/md_extensions/activity_log_item.js
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/chrome/browser/resources/md_extensions/error_page.html
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/chrome/browser/resources/md_extensions/extensions_resources.grd
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/chrome/browser/resources/md_extensions/service.js
[delete] https://crrev.com/eab6e04f58c9f5182a76e00260559f010fc15bec/chrome/browser/resources/md_extensions/shared_style.html
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/chrome/browser/ui/webui/extensions/extensions_ui.cc
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/chrome/common/extensions/api/PRESUBMIT.py
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/chrome/common/extensions/api/_api_features.json
[delete] https://crrev.com/eab6e04f58c9f5182a76e00260559f010fc15bec/chrome/test/data/extensions/activity_log/simple_call/background.js
[delete] https://crrev.com/eab6e04f58c9f5182a76e00260559f010fc15bec/chrome/test/data/extensions/activity_log/simple_call/manifest.json
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/chrome/test/data/extensions/webui/sanity_check_available_apis.js
[delete] https://crrev.com/eab6e04f58c9f5182a76e00260559f010fc15bec/chrome/test/data/webui/extensions/activity_log_test.js
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/chrome/test/data/webui/extensions/test_service.js
[modify] https://crrev.com/7662f4b0a581380e266a3f709a7f9442f6e7138a/testing/buildbot/filters/webui_polymer2_browser_tests.filter
[delete] https://crrev.com/eab6e04f58c9f5182a76e00260559f010fc15bec/third_party/closure_compiler/externs/activity_log_private.js

Labels: -Sheriff-Chromium
Owner: kelvinjiang@chromium.org
Status: Assigned (was: Untriaged)
kelvinjiang: as you landed the original CL can you take a look?
Cc: rdevlin....@chromium.org
Status: Started (was: Assigned)
Taking a look at it.

I think for certain tests, the js code in the flaky test is executed before the API call to fetch the activity log is returned (perhaps because for certain tests, a lot of extension activities can populate the activity log database which slows down API calls to it?).
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bff8e64691124248b4b42e62d65d88e561f97479

commit bff8e64691124248b4b42e62d65d88e561f97479
Author: Kelvin Jiang <kelvinjiang@chromium.org>
Date: Mon Nov 19 22:28:58 2018

[Extensions] Add recent extension activities to the activity log page 2

This is a follow up change to 1321166 which should (hopefully) unflake
the browser e2e test in extension_settings_browsertest.cc, which caused
CL 1321166 to get reverted.

The cause of the flake was that on certain test environments, the API
call to get extension activities was completed after the injected js
code in extension_settings_browsertest.cc was run. This CL attempts to
rectify this by using a promise which is resolved only when the API
call returns, and the test js code is run upon promise resolution.

>> Original CL description below:

Show recent extension activities by making a call to
chrome.activityLogPrivate.getExtensionActivities whenever the user
navigates to the activity log page. Currently, the activity type,
api call, event count and page url (if there is one) are shown
in descending order of event count.

Note: the activity log database can sometimes store more than one entry
that has the same api call/event type. This CL currently does not
group any duplicate activity entries.

Bug: 832354,  905278 
Change-Id: I948d74a707f565f8c074ef4db77532e7fe4b4e3a
Reviewed-on: https://chromium-review.googlesource.com/c/1340876
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609470}
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/app/md_extensions_strings.grdp
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/browser/resources/md_extensions/BUILD.gn
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/browser/resources/md_extensions/activity_log.html
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/browser/resources/md_extensions/activity_log.js
[add] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/browser/resources/md_extensions/activity_log_item.html
[add] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/browser/resources/md_extensions/activity_log_item.js
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/browser/resources/md_extensions/error_page.html
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/browser/resources/md_extensions/extensions_resources.grd
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/browser/resources/md_extensions/service.js
[add] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/browser/resources/md_extensions/shared_style.html
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/browser/ui/webui/extensions/extensions_ui.cc
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/common/extensions/api/PRESUBMIT.py
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/common/extensions/api/_api_features.json
[add] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/test/data/extensions/activity_log/simple_call/background.js
[add] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/test/data/extensions/activity_log/simple_call/manifest.json
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/test/data/extensions/webui/sanity_check_available_apis.js
[add] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/test/data/webui/extensions/activity_log_test.js
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/chrome/test/data/webui/extensions/test_service.js
[modify] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/testing/buildbot/filters/webui_polymer2_browser_tests.filter
[add] https://crrev.com/bff8e64691124248b4b42e62d65d88e561f97479/third_party/closure_compiler/externs/activity_log_private.js

Status: Fixed (was: Started)
Should be fixed, otherwise I would get another revert?

Sign in to add a comment