Tapping fake omnibox doesn't work |
|||
Issue descriptionWhat steps will reproduce the problem? (1) Tap the fake omnibox on the NTP What is the expected result? The omnibox should be focused What happens instead? The fake omnibox is going up but doesn't focus.
,
Nov 14
I can reproduce this only with the top 2 font sizes in the accessibility inspector on simulator.
,
Nov 15
I came across this issue even with smallest font setting.
,
Nov 15
Yes, the issue reproduce with non-default font settings. It is a division which is wrongly rounded up.
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87899a86f424f3d67be019d13d9e70f853a7a62f commit 87899a86f424f3d67be019d13d9e70f853a7a62f Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Nov 16 12:58:40 2018 [iOS] Adjust pinnedYOffset value to neareset pixel This CL makes sure that the value returned by -pinnedYOffset is adjusted to the nearest pixel. This is because when the content size isn't the default one, the value isn't adjusted on a pixel. When it is used to compare to the scroll value of the collection view, this gap prevents the collection view from being considered as completely scrolled. Bug: 905276 Change-Id: Ia44de6063b039a022fcde95e015c3e7df4259308 Reviewed-on: https://chromium-review.googlesource.com/c/1337490 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608748} [modify] https://crrev.com/87899a86f424f3d67be019d13d9e70f853a7a62f/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm [modify] https://crrev.com/87899a86f424f3d67be019d13d9e70f853a7a62f/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/87899a86f424f3d67be019d13d9e70f853a7a62f/ios/chrome/browser/ui/toolbar/toolbar_utils.h [modify] https://crrev.com/87899a86f424f3d67be019d13d9e70f853a7a62f/ios/chrome/browser/ui/toolbar/toolbar_utils.mm
,
Nov 16
,
Nov 20
Issue verified Version: Chrome Canary 72.0.3616.0 Device: iPhone XS iOS: 12.1 Fake omnibox is going up and focus. https://drive.google.com/open?id=1aIXzaaxHPcdRpw3q9OJ58yxoXzqZDk9O |
|||
►
Sign in to add a comment |
|||
Comment 1 by gambard@chromium.org
, Nov 14