New issue
Advanced search Search tips

Issue 905252 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Nov 15
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Blue hover highlight on pdf doesn't vanish after inspecting in dev tools.

Reported by db...@etouch.net, Nov 14 
Chrome Version: 72.0.3610.0 Revision 5bb637264a2fa3603b84e248af301942b7933a61-refs/branch-heads/3610@{#1}(32/64 bit)
OS: Windows(7,8,8.1,10) ,Mac(10.13.1 , 10.13.6 , 10.14.2)  and Linux(14.04 LTS)

Test PDF: https://msu.edu/~urban/sme865/resources/embedded_pdf.html

What steps will reproduce the problem?
(1) Launch chrome, navigate to above PDF and right click on pdf then select 'Inspect' option.
(2) Click on 'Select an element in the page to inspect it' arrow icon then hover on pdf page and click on it.
(3) Observe blue hover highlight on pdf after inspecting it.

Actual: Blue hover highlight on pdf doesn't vanish after inspecting it.

Expected: Blue hover highlight on pdf should vanishes after inspecting it.

This is a regression issue, broken in 'M72', below is bisect info:

Good Build:72.0.3598(Revision: 604472)
Bad Build: 72.0.3599(Revision: 604791)

Chrommium bisect:

https://chromium.googlesource.com/chromium/src/+log/d833bb6b23a98904d06ba045f07d15409e373e2b..7054c49c2d993a2ec898340db2cad1c372ab2223?pretty=fuller&n=100

Suspect: https://chromium.googlesource.com/chromium/src/+/6d8ff26fcfe69dfbfb8e687169f362fec1834600

@luoe: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank you.
Actual_Highlight.mp4
2.3 MB View Download
Expected_Highlight.mp4
1.6 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb1a4687d53112eba231613f92d018c116850eaf

commit bb1a4687d53112eba231613f92d018c116850eaf
Author: Erik Luo <luoe@chromium.org>
Date: Thu Nov 15 22:17:45 2018

DevTools: do not highlight selected node on DevTools focus

Switching windows or using the Element picker may focus the DevTools
area with relatedTarget=null. In these cases, re-applying node
highlight is not needed.

Bug:  905252 
Change-Id: Ie3ae228c9cc404f16598ff428d9e593bb90e33e5
Reviewed-on: https://chromium-review.googlesource.com/c/1336910
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608541}
[modify] https://crrev.com/bb1a4687d53112eba231613f92d018c116850eaf/third_party/blink/renderer/devtools/front_end/elements/ElementsTreeOutline.js

Comment 2 by l...@chromium.org, Nov 15

Status: Fixed (was: Assigned)
Thank you so much for finding and filing this so quickly.  Much appreciated.

Comment 3 by db...@etouch.net, Nov 16

Labels: TE-Verified-M72 TE-Verified-72.0.3612.0
Update: 
Rechecked the above issue on canary build #72.0.3612.0 using Windows(7,8,8.1,10) ,Mac(10.13.1 ,10.13.6 ,10.14.2) and Linux(14.04 LTS and it is fixed.

Thank you.
Actual_Fix.mp4
1.6 MB View Download
►

Sign in to add a comment