Port arc_auth_service_browsertest.cc to IdentityManager |
||||
Issue descriptionAs the browsertest uses FakePO2TS and FakeSigninManager, this conversion should be doable via IdentityTestEnvironmentProfileAdaptor.
,
Nov 20
I'm taking this
,
Nov 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3222fbdd72c4f274f2e85653cfe49fe6998c6a94 commit 3222fbdd72c4f274f2e85653cfe49fe6998c6a94 Author: Sergio Villar Senin <svillar@igalia.com> Date: Thu Nov 22 18:12:42 2018 Port arc_auth_service_browsertest.cc to IdentityManager It was using both SigninManager and ProfileOAuth2TokenService fakes to seed primary&secondary account info and update their refresh tokens. Replaced them by the correspondent identity API calls via an IdentityTestEnvironmentProfileAdaptor which is also used to create the testing profile. Bug: 905247 Change-Id: I8cdca4c9ade423cf9e431fd0420f6db5411935b3 Reviewed-on: https://chromium-review.googlesource.com/c/1346094 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#610465} [modify] https://crrev.com/3222fbdd72c4f274f2e85653cfe49fe6998c6a94/chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc
,
Nov 23
,
Nov 23
Already fixed |
||||
►
Sign in to add a comment |
||||
Comment 1 by blundell@chromium.org
, Nov 14