New issue
Advanced search Search tips

Issue 905247 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 23
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318
issue 883330



Sign in to add a comment

Port arc_auth_service_browsertest.cc to IdentityManager

Project Member Reported by blundell@chromium.org, Nov 14

Issue description

As the browsertest uses FakePO2TS and FakeSigninManager, this conversion should be doable via IdentityTestEnvironmentProfileAdaptor.
 
Blocking: 883330 883318
Status: Started (was: Available)
I'm taking this
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3222fbdd72c4f274f2e85653cfe49fe6998c6a94

commit 3222fbdd72c4f274f2e85653cfe49fe6998c6a94
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Thu Nov 22 18:12:42 2018

Port arc_auth_service_browsertest.cc to IdentityManager

It was using both SigninManager and ProfileOAuth2TokenService fakes to
seed primary&secondary account info and update their refresh
tokens. Replaced them by the correspondent identity API calls via an
IdentityTestEnvironmentProfileAdaptor which is also used to create the
testing profile.

Bug:  905247 
Change-Id: I8cdca4c9ade423cf9e431fd0420f6db5411935b3
Reviewed-on: https://chromium-review.googlesource.com/c/1346094
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610465}
[modify] https://crrev.com/3222fbdd72c4f274f2e85653cfe49fe6998c6a94/chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc

Owner: svil...@igalia.com
Status: Fixed (was: Started)
Already fixed

Sign in to add a comment