Port ArcAuthContext away from ProfileOAuth2TokenService |
|||||||
Issue descriptionThe API usage is all straightforward. It's also passed into UbertokenFetcher, so we won't be able to remove it completely until we have a solution for that (I'll file a bug for that and block this bug on it). But we can remove all its other usage in this file now.
,
Nov 20
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9da9604039b057b10c25909ebea068f0d8116221 commit 9da9604039b057b10c25909ebea068f0d8116221 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Wed Nov 21 20:04:12 2018 [s13n] Convert ArcAuthContext away from ProfileOAuth2TokenService CL converts ArcAuthContext away from PO2TS, as part of the IdentityManager servicification effort (//services/identity). No functionality change is expected. Note that there is still one reference to PO2TS left, that is used to construct UbertokenFetcher. It will be removed on a follow up pass. CL also takes the opportunity to migrate ArcBackgroundAuthCodeFetcher away from OAuth2TokenService::Consumer, since it is tied to ArcAuthContext. BUG= 905243 TEST=Run on test device. TEST=Run browser_tests --gtest_filter=Arc* TEST=Run unit_tests --gtest_filter=Arc* Change-Id: I1a74df3b79a7753e96dc7993d636692efa18d1a0 Reviewed-on: https://chromium-review.googlesource.com/c/1345130 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#610189} [modify] https://crrev.com/9da9604039b057b10c25909ebea068f0d8116221/chrome/browser/chromeos/arc/auth/arc_auth_context.cc [modify] https://crrev.com/9da9604039b057b10c25909ebea068f0d8116221/chrome/browser/chromeos/arc/auth/arc_auth_context.h [modify] https://crrev.com/9da9604039b057b10c25909ebea068f0d8116221/chrome/browser/chromeos/arc/auth/arc_background_auth_code_fetcher.cc [modify] https://crrev.com/9da9604039b057b10c25909ebea068f0d8116221/chrome/browser/chromeos/arc/auth/arc_background_auth_code_fetcher.h
,
Nov 21
,
Dec 10
Re-opening this to track removing the last usage once our solution for porting away from UbertokenFetcher is available (see blocking bug).
,
Jan 12
Ongoing in CL https://chromium-review.googlesource.com/c/chromium/src/+/1407012
,
Jan 14
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09deb66290457e5653b69e995a884100852ae6f6 commit 09deb66290457e5653b69e995a884100852ae6f6 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Wed Jan 16 02:52:35 2019 Port current clients of UbertokenFetcher away from PO2TS This CL is the last out of 4 CLs to incorporate UbertokenFetcher into the IdentityManager API. TL;DR: CL allows us to get rid of the PO2TS references from GaiaWebAuthFlow and ArcAuthContext by making UbertokenFetcher available through IdentityManager API. In details, the CL: 1) Introduces an UbertokenFetcher base class to //components/signin/core/browser, compiled as part of the "shared" GN target. The class is very simple, and used mainly to expose UbertokenFetcher through an IdetntiyManager API. 2) Adds an entry point API IdentityManager::CreateUbertokenFetcher() that returns an instance of UbertokenFetcherImpl (actually for clients of this API see the return as an UbertokenFetcher object). 4) Changes the two client-side consumers of the previous UbertokenFetcher implementation to indirectly instantiate UbertokenFetcherImpl obtained via IdentityManager::CreateUbertokenFetcher. BUG= 905243 , 906025 Change-Id: I419b8af26485ab94c5efdcdefd7fd18ce48c8a8e Reviewed-on: https://chromium-review.googlesource.com/c/1407012 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#623071} [modify] https://crrev.com/09deb66290457e5653b69e995a884100852ae6f6/chrome/browser/chromeos/arc/auth/arc_auth_context.cc [modify] https://crrev.com/09deb66290457e5653b69e995a884100852ae6f6/chrome/browser/chromeos/arc/auth/arc_auth_context.h [modify] https://crrev.com/09deb66290457e5653b69e995a884100852ae6f6/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc [modify] https://crrev.com/09deb66290457e5653b69e995a884100852ae6f6/chrome/browser/extensions/api/identity/gaia_web_auth_flow.h [modify] https://crrev.com/09deb66290457e5653b69e995a884100852ae6f6/components/signin/core/browser/BUILD.gn [add] https://crrev.com/09deb66290457e5653b69e995a884100852ae6f6/components/signin/core/browser/ubertoken_fetcher.cc [add] https://crrev.com/09deb66290457e5653b69e995a884100852ae6f6/components/signin/core/browser/ubertoken_fetcher.h [modify] https://crrev.com/09deb66290457e5653b69e995a884100852ae6f6/components/signin/core/browser/ubertoken_fetcher_impl.h [modify] https://crrev.com/09deb66290457e5653b69e995a884100852ae6f6/services/identity/public/cpp/DEPS [modify] https://crrev.com/09deb66290457e5653b69e995a884100852ae6f6/services/identity/public/cpp/identity_manager.cc [modify] https://crrev.com/09deb66290457e5653b69e995a884100852ae6f6/services/identity/public/cpp/identity_manager.h
,
Jan 16
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by blundell@chromium.org
, Nov 16