New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 905234 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression:[NTP]URL text appears twice after clicking on 'Redo' option of context menu

Reported by vineetha...@etouch.net, Nov 14

Issue description

Chrome Version: 71.0.3578.53 (Official Build) Revision	599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}(32/64-bit)
OS: Windows(7,8,8.1,10),  Mac (10.13.1, 10.13.6, 10.14.2) and Linux(14.04)

Pre-condition: Enable "Enable using the Google local NTP" and "New Tab Page Custom Links" flags under chrome://flags.

What steps will reproduce the problem?
1. Launch chrome, open NTP, open 'Add shortcut' overlay.
2. Enter any text in URL text field and press 'Esc' to close the overlay.
3. Now open 'Add shortcut' overlay again, right click on URL text field and click on 'Undo' option.
4. Now right click again on URL text field and click on 'Redo' option from context menu and observe.

Actual Result  : URL text appears twice after clicking on 'Redo' option of context menu.
Expected Result: URL text should not appear twice after clicking on 'Redo' option of context menu.

This is a regression issue broken in ‘M-70’ and below is the 'per-revision' bisect information:
Good Build : 70.0.3532.0 (Revision : 585633)
Bad Build  : 70.0.3533.0 (Revision : 586155)

You are probably looking for a change made after 586023 (known good), but no later than 586024 (first known bad).

CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.  

https://chromium.googlesource.com/chromium/src/+log/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74..90512ec79cc3358a8072bdad4718c54ea0961638

Suspect: https://chromium.googlesource.com/chromium/src/+/90512ec79cc3358a8072bdad4718c54ea0961638

@kristipark: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly refer the attached screen-cast.

Thank you

 
ActualVideo.mp4
499 KB View Download
ExpectedBehaviour.mp4
446 KB View Download
Labels: -Pri-1 -Target-70 -Target-71 -Target-72 Target-73 Pri-3
Targeting M73 since M72 branch is coming soon
Labels: O-Polish-Birthday-Features KR-NTP-MD2-Polish
Labels: small
Labels: zine-triaged
Cc: kristip...@chromium.org
Owner: tinazwang@chromium.org
Click Done/Cancel button will also reproduce the problem.
In Chrome, calling undo/redo to an input element after a reset function has been called will cause duplicate text. 

This issue need to be escalated.
Owner: keishi@chromium.org
Debugged a bit more, and found that I was able to reproduce this in Safari using this example:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/reset#A_simple_reset_button
Note this doesn't reproduce in Firefox since undo is disabled after the form resets.

Assigning to keishi, let me know if you're the right person for this.
Cc: tinazwang@chromium.org

Sign in to add a comment