New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 905226 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: current == static_cast<Sample>(std::round(exp(log_current))) in histogram.cc

Project Member Reported by ClusterFuzz, Nov 14

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4981965520109568

Fuzzer: mojo_fuzzer
Job Type: linux_asan_chrome_mojo
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  current == static_cast<Sample>(std::round(exp(log_current))) in histogram.cc
  base::Histogram::InitializeBucketRanges
  base::Histogram::Factory::CreateRanges
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mojo&range=607795:607803

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4981965520109568

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 14

Components: Internals>Metrics
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 14

Labels: Test-Predator-Auto-Owner
Owner: bcwh...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/2aaa8b01affcd08c5eb0ef0d1edc60d6f15ee7eb (Check log() operation on current value.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cfaffb1b47f922c8d51c26d2846692f85d9e608

commit 7cfaffb1b47f922c8d51c26d2846692f85d9e608
Author: Brian White <bcwhite@chromium.org>
Date: Thu Nov 15 16:51:31 2018

Fix InspectConstructionArguments with random min & max.

If the min/max parameters are really fubar, such as which might come
from a malicious IPC message, min & max can be limited only to then
be swapped and become invalid.  Do the swap first.

Also, remove duplicate bucket-limit condition and set the defined
maximum to be the lower of the two.

Bug:  905226 
Change-Id: If73e97e43e93704f93456da6af0708422fa145a0
Reviewed-on: https://chromium-review.googlesource.com/c/1335731
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608398}
[modify] https://crrev.com/7cfaffb1b47f922c8d51c26d2846692f85d9e608/base/metrics/histogram.cc
[modify] https://crrev.com/7cfaffb1b47f922c8d51c26d2846692f85d9e608/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)
Project Member

Comment 5 by ClusterFuzz, Nov 16

ClusterFuzz has detected this issue as fixed in range 608397:608398.

Detailed report: https://clusterfuzz.com/testcase?key=4981965520109568

Fuzzer: mojo_fuzzer
Job Type: linux_asan_chrome_mojo
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  current == static_cast<Sample>(std::round(exp(log_current))) in histogram.cc
  base::Histogram::InitializeBucketRanges
  base::Histogram::Factory::CreateRanges
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mojo&range=607795:607803
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mojo&range=608397:608398

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4981965520109568

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Nov 16

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4981965520109568 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment